Magic Link Login #1598
Magic Link Login #1598
Conversation
|
You can test the changes in simplenote-ios from this Pull Request by:
|
|
|
||
| - vertical_whitespace | ||
| # - vertical_whitespace |
There was a problem hiding this comment.
Disabling this, so that we stop chasing whitespaces or extra newlines, all over the place
|
Overall this is looking good, going to wait to approve until we have the email link working (protocol not being stripped in gmail). Nice work Jorge! |
|
|
||
| // MARK: - LoginRemote | ||
| // | ||
| class LoginRemote: Remote { |
There was a problem hiding this comment.
Is this that different from AccountRemote? for the passkey remote things I dumped them in AccountRemote I don't mind the specifically targeted class, but 🤔
There was a problem hiding this comment.
(Belayed reply!!) This one is indeed different from AccountRemote. Account encapsulates Email Verification + Account Deletion.
I'd be super okay with merging them both, though. I'll revisit in a follow-up, TY!!
|
|
||
| // MARK: - MagicLinkRequestedView | ||
| // | ||
| struct MagicLinkRequestedView: View { |
There was a problem hiding this comment.
Currently almost all of the SwiftUI in SNiOS is done with UIKit. The only swiftUI we are using is in the widgets, where it is required. Do we want to start mixing UIKit and SwiftUI?
There was a problem hiding this comment.
Discussed over Slack, but leaving a note here, for the record!!
IMHO SwiftUI is all good, as long as it doesn't cause problems. That'd be: perhaps we should just try avoid blending SwiftUI + UIKit in the same UI, because of the (known) layout loops.
TY for bringing this up!!
|
|
||
| /// Performs a URLSession Data Task | ||
| /// | ||
| func performDataTask(with request: URLRequest) async throws -> Data { |
Generated by 🚫 Danger |
|
Thank you Charlie!! We'll need to follow-up this PR, and also allow for Code Verification. Merging this one!! |
Details
This PR implements Magic Link Authentication support.
Ref. #1605
Test
Login>Login with EmailInstantly Log In with EmailLog In(in your email!), Simpenote logs you inLog Inbutton again, you won't get logged inTest: Regressions
Login with EmailContinue with PasswordbuttonForgot Passwordopens the Password Recovery UI in a WebViewRelease
RELEASE-NOTES.txtwas updated in e1d5c04 with: