Login with Passkeys!! #1599
Merged
Login with Passkeys!! #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
You can test the changes in simplenote-ios from this Pull Request by:
|
charliescheer
changed the title
charliescheer
changed the title
roundhill
reviewed
Jun 25, 2024
…ge by ensuring it is url safe.
charliescheer
force-pushed
the
charlie/passkey-implementation
branch
from
7e524e0
to
23ed723
Compare
jleandroperez
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
@charliescheer We'd need to polish all of the flows:
- Entering the wrong password during the Passkey Registration results in no feedback
- I was unable to associate the 1P entry I had, with the new Passkey
- The Onboarding flow also results in no feedback, if you previously didn't have a Passkey
That being said, since we're targetting a feature branch, no blockers to merge this one!
Nice work!!
| static let alertTitle = NSLocalizedString("Passkey Setup", comment: "Alert title for setting up passkeys") | ||
| static let message = NSLocalizedString("To add passkeys you must enter your password", comment: "Message prompting user for password to create passkey") | ||
| static let submit = NSLocalizedString("Submit", comment: "Submit button title") | ||
| static let cancel = NSLocalizedString("cancel", comment: "Cancel button title") |
There was a problem hiding this comment.
Nipticky: We should prob. capitalize this one
|
Entering the wrong password during the Passkey Registration results in no feedback Yes! All of that stuff is coming in a future PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
To improve the security of Simplenote accounts we are trying to move away from email/password authentication as it is insecure at best. One of the things we are implementing is Passkeys. This will allow users to create and store passkeys on their apple device and when they go to log into their account rather than using an email and password they only need to put in their email and then use the local biometrics to receive a passkey and then authenticate into Simplenote.
This has a bunch of security benefits and should also help users keep from losing their passwords.
Sign up for passkeys:
RPReplay_Final1718384460.mp4
Login with passkeys:
RPReplay_Final1718384268.mp4
Test
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txtif the changes should be included in release notes. Include details about updating the notes in this section. For example: