Invalid Authentication Link Alert

[jleandroperez]

Fix

In this PR we're building a UI, to be presented whenever the user attempts to authenticate using a link that's no longer valid.

Closes #1605

Test: From Onboarding

1. Fresh install Simplenote iOS
2. Make sure you're logged out!
3. Switch to Safari and open: simplenote://login?auth_key=1234&auth_code=5678

• Verify Simplenote ends up in the Foreground
• Verify that shortly after you get an alert, indicating that the Magic Link isn't valid
• Verify that pressing the Request new Link button gets you back into the Login UI

Test: From Login UI!

1. Fresh install Simplenote iOS
2. Make sure you're logged out!
3. Press on the Log In button
4. Switch to Safari and open: simplenote://login?auth_key=1234&auth_code=5678

• Verify that the Invalid Link Alert is also presented
• Verify that pressing the Request new Link button gets you back into the Login UI

Test: From Login UI!

1. Fresh install Simplenote iOS
2. Make sure you're logged out!
3. Press on the Sign Up button
4. Switch to Safari and open: simplenote://login?auth_key=1234&auth_code=5678

• Verify that the Invalid Link Alert is also presented
• Verify that pressing the Request new Link button gets you back into the Login UI

Release

These changes do not require release notes.

[wpmobilebot]

You can test the changes in simplenote-ios from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr1606-eb62589-0190745a-1e5b-4029-9085-d667ab85756c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[charliescheer]

I think there is some duplication here with the invalid view and the check your email view. They are the same except that the invalid view has the new link button. Not sure if it is worth it, but I wonder if there is a way to save on the duplication here

[charliescheer]

👍

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[jleandroperez]

RE: MagicLinkView(s), we'll need to revisit the UX for this flow. Following up in another PR.

Thank you Charlie!!