Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Links: Adjusting Copy #1613

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Magic Links: Adjusting Copy #1613

merged 2 commits into from
Jul 15, 2024

Conversation

jleandroperez
Copy link
Contributor

Fix

(Required) Add a concise description of what you fixed. If this is related to an issue, add a link to it. If applicable, add screenshots, animations, or videos to help illustrate the fix.

Test

  1. Paste this into iMessage (or any other messaging app you've got on your phone!!): https://app.simplenote.com/login?email=eW91cmVtYWlsQGxhbGFsYS5jb20==&auth_code=A000
  2. Press on the link
  • Verify Simplenote iOS ends up in the foreground
  • Verify that you get a UI indicating that the link is no longer valid
  • Verify that the changes make sense!

Screenshots

Release

These changes do not require release notes.

@jleandroperez jleandroperez added the enhancement Improve existing functionality. label Jul 11, 2024
@jleandroperez jleandroperez added this to the 4.52 milestone Jul 11, 2024
@jleandroperez jleandroperez self-assigned this Jul 11, 2024
@jleandroperez jleandroperez marked this pull request as ready for review July 11, 2024 18:44
@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1613-6d779c0-0190a31b-ef35-4077-9bea-1ebcc557f7cf on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from lantean/1611-updates-magic-link-endpoints to trunk July 15, 2024 19:57
@jleandroperez
Copy link
Contributor Author

Thank you Charlie!!

@jleandroperez jleandroperez merged commit 747c3ef into trunk Jul 15, 2024
14 of 16 checks passed
@jleandroperez jleandroperez deleted the lantean/adjusting-copy branch July 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants