-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio: Update php-wasm ( playground dependecies) #491
Conversation
… commands (eg core update)
Things I have tested:
|
I smoke tested the app with the build from this branch and everything worked as expected. The only thing that I noticed is that this branch is about 20 - 30 seconds slower for me when importing a database. Steps to reproduce:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I smoke tested the app, tried several different plugins and themes and everything is running as expected for me 👍
I noticed that sometimes importing could be slower compared to trunk but I was not able to reproduce this consistently so I am suspecting that it might be a specific import file at fault.
Fixes https://github.com/Automattic/dotcom-forge/issues/8867
Proposed Changes
This PR updates the following packages to the latest version:
During the update we ran into various issues, some of which required changes in the wordpress-playground repository:
We had to change a couple of things in the current implementation of wp-now within Studio as it was relying on outdated APIs. These changes mainly relate to how we obtain a PHP instance.
Testing Instructions
Pre-merge Checklist