Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add epic/* release workflow and rename master to trunk #170

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 1, 2024

All Submissions:

Changes proposed in this Pull Request:

  1. Adds a new epic/* release workflow for creating release builds that we can use for beta testing and other QA purposes. This workflow is similar to alpha and hotfix/* workflows, but kind of in between them.
  2. Renames the master branch to trunk.

How to test the changes in this Pull Request:

Follow testing instructions in Automattic/newspack-plugin#2895, but for this repo.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Feb 1, 2024
@dkoo dkoo requested a review from a team as a code owner February 1, 2024 18:21
Copy link

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one final instance of master to replace in the codebase then this is good to go:

__( 'If the automatic positioning causes problems for any given post, you can prevent automatic placement of the ads <a href="https://github.com/Automattic/super-cool-adinserter-plugin/blob/master/docs/display-settings.md">using a shortcode</a> or disable them completely by checking this box:', 'scaip' ),

Gonna go ahead and approve since its a trivial change.

@dkoo
Copy link
Contributor Author

dkoo commented Feb 1, 2024

@chickenn00dle good catch! Fixed in 42c3f85.

@chickenn00dle
Copy link

Ah whoops! I approved prematurely @dkoo and only verified the code. Didnt follow the steps in Automattic/newspack-plugin#2895.

Sorry! Will do that now!

@dkoo dkoo merged commit bf6d042 into trunk Feb 1, 2024
1 check passed
@dkoo dkoo deleted the feat/epic-release-workflow branch February 1, 2024 21:17
matticbot pushed a commit that referenced this pull request Feb 8, 2024
# [0.7.0-alpha.1](v0.6.3...v0.7.0-alpha.1) (2024-02-08)

### Features

* **ci:** add epic/* release workflow and rename `master` to `trunk` ([#170](#170)) ([bf6d042](bf6d042))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 0.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 24, 2024
# [0.7.0](v0.6.3...v0.7.0) (2024-04-24)

### Features

* **ci:** add epic/* release workflow and rename `master` to `trunk` ([#170](#170)) ([bf6d042](bf6d042))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants