Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolbar code selection for latest Gutenberg versions #200

Merged
merged 5 commits into from
Mar 10, 2021
Merged

Fix toolbar code selection for latest Gutenberg versions #200

merged 5 commits into from
Mar 10, 2021

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Mar 9, 2021

Changes proposed in this Pull Request

  • Recently Gutenberg received this commit, which made the code language selection stop showing the selected label in the toolbar. So this PR fixes it (using the same approach used for Sensei LMS plugin).
  • It also adds 2 small fixes:
    • Keys in some parts where it was missing.
    • Fix a style property.

Testing instructions

  • Create an env with WP 5.7, or with the latest Gutenberg version.
  • Add a SyntaxHighlighter block to a post or page.
  • Make sure you see and you're able to select the code language through the block toolbar.

Screenshot / Video

Screen.Recording.2021-03-09.at.17.45.23.mov

@renatho renatho added this to the v3.6.0 milestone Mar 9, 2021
@renatho renatho requested a review from gikaragia March 9, 2021 20:47
@renatho renatho self-assigned this Mar 9, 2021
@renatho renatho changed the title Fix toolbar code selection Fix toolbar code selection for latest Gutenberg versions Mar 9, 2021
@renatho renatho requested a review from alexsanford March 9, 2021 21:04
alexsanford
alexsanford approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well!

@renatho renatho merged commit 52e98ba into master Mar 10, 2021
@renatho renatho deleted the fix/toolbar-code-selection branch March 10, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsanford alexsanford alexsanford approved these changes

@gikaragia gikaragia Awaiting requested review from gikaragia

Assignees

@renatho renatho

Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@renatho @alexsanford