Migrate project to wp-scripts and fix lodash deps #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgcaruso
approved these changes
Nov 22, 2023
Comment on lines
+63
to
+66
| let itemClassNames = 'syntaxhighlighter-toolbar-dropdown__option'; | ||
| if ( isSelected ) { | ||
| itemClassNames += ' is-selected'; | ||
| } |
There was a problem hiding this comment.
Just curious why classnames needed to be removed? Personally I think its cleaner to use that instead of manual string building, from a readability perspective.
There was a problem hiding this comment.
It was in order to clean up dependencies for things marginally used, seems a bit overkill to use a 3rd party npm package to do a string concatenation ... once 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Changes proposed in this Pull Request
Testing instructions
npm run build