Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: Unexpected formatting colours #4616

Open
mikachan opened this issue Sep 15, 2021 · 3 comments
Open

Blockbase: Unexpected formatting colours #4616

mikachan opened this issue Sep 15, 2021 · 3 comments
Labels
[Theme] Blockbase [Type] Bug Something isn't working

Comments

@mikachan
Copy link
Member

Steps to replicate

The code block has an unexpected grey border in the editor and no border on the front end:

Editor Front end
image image

Example markup:

<!-- wp:code -->
<pre class="wp-block-code"><code>The code block starts with
&lt;!-- wp:code --&gt;
&lt;?php echo 'Hello World'; ?&gt;
</code></pre>
<!-- /wp:code -->

In a striped style table, the cells with background colours use an unexpected colour:

image

Example markup:

<!-- wp:table {"hasFixedLayout":true,"className":"is-style-stripes"} -->
<figure class="wp-block-table is-style-stripes"><table class="has-fixed-layout"><tbody><tr><td>This is the striped style.</td><td>This row should have a background color.</td></tr><tr><td>The cell next to this is empty.</td><td><br><br></td></tr><tr><td></td><td>This table has fixed width table cells.<br></td></tr><tr><td><br>Make sure that the text wraps correctly.<br><br></td><td></td></tr></tbody></table></figure>
<!-- /wp:table -->
@mikachan mikachan added [Type] Bug Something isn't working [Theme] Blockbase labels Sep 15, 2021
@danieldudzic
Copy link
Contributor

danieldudzic commented Sep 17, 2021

I can't replicate this one

can_t_replicate

:

@mikachan
Copy link
Member Author

Hey @kjellr. For the second issue mentioned here about striped table colors, it looks like Gutenberg doesn't support custom colors for this style of table yet, only the default style. There's an ongoing issue for table block enhancements: WordPress/gutenberg#31261

Can you think of a bandaid solution that would make sense here, or should we wait for the final fix?

@kjellr
Copy link
Contributor

kjellr commented Sep 22, 2021

This is low priority, so I'm happy to wait for new functionality in Gutenberg.

@jeffikus jeffikus modified the milestone: Blockbase Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Blockbase [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants