Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Continued enhancement of color options #31261

Open
1 of 3 tasks
Tracked by #32400 ...
aaronrobertshaw opened this issue Apr 28, 2021 · 2 comments
Open
1 of 3 tasks
Tracked by #32400 ...

Table: Continued enhancement of color options #31261

aaronrobertshaw opened this issue Apr 28, 2021 · 2 comments
Assignees
Labels
[Block] Table Affects the Table Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented Apr 28, 2021

Follow-up to #30791

Current Situation

The table block has recently been switched to use block supports to provide greater control over background and text colors.

It was decided that change was a good first step however we need to address some additional issues such as:

  • allowing control of table border color
  • specifying different colors for table headers and footers
  • contrast issues with the striped style
  • providing control over secondary background or font colors when striped style is selected

See: #30791 (comment)

Example Designs Enabled By This

Frame 61
Frame 60
Frame 58

Next Steps

The lowest hanging fruit here will be adding control of the border color. We already have border color block support that can be leveraged to achieve this.

Next, adding control over the secondary background and font colors should help to address contrast issues.

Exploring separate color selections for table headers and footers might be the trickiest if we wish to minimise the number of color controls we are adding to the sidebar.

Tasks

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Table Affects the Table Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Apr 28, 2021
@aaronrobertshaw aaronrobertshaw self-assigned this Apr 28, 2021
@aaronrobertshaw
Copy link
Contributor Author

Border support has been added to the Table block via #31264 & #31265.

The first PR adds utilities to collect border support CSS classes and styles when skipping serialization. The second uses those to provide border support to the Table block.

@carolinan
Copy link
Contributor

Link color should also be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
Status: 🔺 Stale
Development

No branches or pull requests

2 participants