Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Luminance] - Featured images are misaligned. #7910

Closed
Greatdane opened this issue Jul 2, 2024 · 10 comments
Closed

[Luminance] - Featured images are misaligned. #7910

Greatdane opened this issue Jul 2, 2024 · 10 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal [Theme] Luminance Triaged [Type] Bug Something isn't working

Comments

@Greatdane
Copy link

Quick summary

Check the demo site; https://luminancedemo.wordpress.com/

The featured images within the query loop are misaligned. Just reported by a user and can reproduce.

CleanShot 2024-07-02 at 13 27 38@2x

Steps to reproduce

Activate Luminance and check the homepage template in the site editor.

What you expected to happen

Featured image should be aligned.

What actually happened

Featured image is not aligned.

Browser

Google Chrome/Chromium, Mozilla Firefox, Microsoft Edge, Apple Safari

Context

Customer Report.

Platform (Simple, Atomic, or both?)

Simple

Other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, difficult to implement

Workaround details

Likely CSS. Not Available to Starter plans.

@Greatdane
Copy link
Author

8404697-zd-a8c

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8404697-zen
  • 8404682-zen
  • 8428324-zen
  • 8460124-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jul 2, 2024
@marutim
Copy link

marutim commented Jul 2, 2024

Another report here: 8404682-zen

@jartes
Copy link

jartes commented Jul 4, 2024

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Could Not Replicate

📌 FINDINGS
On atomic sites, this is not happening, as they have the following CSS to fix that:

.wp-block-post-featured-image.wp-block-post-featured-image img {
    vertical-align: top;
width: auto;
}

📌 ACTIONS

  • Triaged
  • Adding normal priority

@lizswafford
Copy link

8428324-zd-a8c

@supernovia
Copy link

Another report here. 8460124-zd-a8c

This is an atomic site. We'll add the CSS but noting it does occur there by default.

@dsas
Copy link
Contributor

dsas commented Aug 12, 2024

Luminance sets core/post-featured-image to vertical-align:top which would correct the display but this is being overridden to vertical-align:bottom by the more specific CSS in post-features-image/style.css since WP 6.6 downgraded CSS specificity.

@dsas
Copy link
Contributor

dsas commented Aug 12, 2024

Filed WordPress/gutenberg#64453 upstream

@seanbelly
Copy link

Another report here: 8554300-zd-a8c

@alaczek
Copy link
Contributor

alaczek commented Aug 20, 2024

Fixed in #8023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal [Theme] Luminance Triaged [Type] Bug Something isn't working
Development

No branches or pull requests

8 participants