Update shape of theme.json file #3133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with WordPress/gutenberg#28110 the theme.json file has been updated to reflect the new expected shape.
pbking
force-pushed
the
update/spearhead-shape-of-json
branch
from
777cc66
to
7268161
Compare
pbking
changed the title
|
I guess we'll have to time the merging of this one carefully... |
|
Are any of the themes on .com using |
Yeah, that's right, it's not vital :) |
|
What version of Gutenberg is this change shipping in? |
|
Moving to blocked until 9.9 ships on wpcom |
|
FYI @scruffian @pbking 9.9.2 is on .com. p7DVsv-auF-p2 |
|
this has been corrected elsewhere, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In accordance with
WordPress/gutenberg#28110
the theme.json file has been updated to reflect the new expected shape.
This was tested locally with Gutenberg 9.8.2 on the /master branch. This will NOT work on .com until that version of Gutenberg has been deployed there. However ONCE IT IS then fixes for #3106 and #3122 will no longer work.
Related issue(s):
#3106 are related as is #3122
WordPress/theme-experiments#182 is similar but for TT1-blocks.