-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank Canvas: Add the "Subscription Form and Links" pattern #3416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I didn't see the validation error. The jetpack form looks very different on the front/back but that's outside of the scope of this...
@jffng were you testing on WP.com? I just want to make sure we can't reproduce before merge. |
Yes — tested on a simple site. I will give it another spin on different site to see if I can still recreate it. |
Confirm this happens every time I insert the pattern on a sandboxed simple site. This is the console error:
|
@jffng I tried on a couple test sites and was unable to reproduce. Is your sandbox up to date? |
It was not! Working now 🚢 |
Adds the Jetpack Subscribe + Links pattern from #3161, now that Automattic/jetpack#18085 has been resolved. This PR also properly escapes the wpcom-only block pattern strings + URLs to match up with the changes made in #3345.
Two small caveats:
Screenshots
Editor:
Front End: