Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: refactor template part blocks #5129

Merged
merged 22 commits into from
Dec 6, 2021

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Dec 1, 2021

Changes proposed in this Pull Request:

This PR refactors our use of wp:template-part blocks, as they no longer support layout, color, or spacing.

Related GB PR: WordPress/gutenberg#36571

Related issue(s):

Closes #5113

@mikachan mikachan self-assigned this Dec 1, 2021
@mikachan mikachan marked this pull request as ready for review December 3, 2021 11:08
@mikachan mikachan requested a review from a team December 3, 2021 11:08
@scruffian
Copy link
Member

I wonder if we should move the wrapper inside the post-meta-icons template as well?

@mikachan
Copy link
Member Author

mikachan commented Dec 4, 2021

I wonder if we should move the wrapper inside the post-meta-icons template as well?

Yeah good shout, on it!

@scruffian
Copy link
Member

@Automattic/flow-patrol-manage this will need to happen in our premium themes too.

@scruffian scruffian merged commit 7f238fa into trunk Dec 6, 2021
@scruffian scruffian deleted the update/5113-remove-template-part-styles branch December 6, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block themes: remove styles from template parts
2 participants