Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course Theme - Fix post title spacings for course and lesson default #7294

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Course Theme - Fix post title spacings for course and lesson default #7294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e490b32
Add single lesson template
Imran92 Jul 25, 2023
f6ee290
Add single lesson template in theme.json
Imran92 Jul 25, 2023
7b8c09c
Change template name from Single Lesson to Lesson
Imran92 Aug 2, 2023
a2881e5
Remove single-lesson template from lesson dropdown
Imran92 Aug 2, 2023
6ad7328
Move template removing hook to separate function
Imran92 Aug 3, 2023
b8357e2
Fix margin for single course and lesson template
Imran92 Aug 7, 2023
90d33b4
Remove non responsive spacing from single course template
Imran92 Aug 7, 2023
477e3a2
Remove non responsive spacing single lesson template
Imran92 Aug 7, 2023
469dbf6
Merge branch 'trunk' into fix/post-title-spacing-fix-course-lesson
Imran92 Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions course/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,13 @@ body.page-template-page-wide-width footer .wp-block-group {
/*
* Sensei-specific styles
*/
body[class*="-template-single-course"] .wp-block-post-title,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the following 2 CSS classes are the ones that style courses and lessons, so I'm wondering which use case this selector is needed for?

body.course-template-default .wp-block-post-title,
body.single-lesson:not(.sensei-course-theme) .wp-block-post-title {
margin-top: clamp(0.875rem, -0.394rem + 4.231vw, 2.25rem);
margin-bottom: clamp(2.5rem, 0.192rem + 7.692vw, 5rem);
}

.wp-block-sensei-lms-course-overview a {
text-decoration: underline;
}
Expand Down
2 changes: 1 addition & 1 deletion course/templates/single-course.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<main class="wp-block-group" style="margin-bottom:80px;">
<!-- wp:group {"layout":{"inherit":true,"type":"constrained","contentSize":"1000px"}} -->
<div class="wp-block-group">
<!-- wp:post-title {"level":1,"align":"wide","style":{"spacing":{"margin":{"bottom":"5rem"}}}} /-->
<!-- wp:post-title {"level":1,"align":"wide"} /-->
</div>
<!-- /wp:group -->

Expand Down
2 changes: 1 addition & 1 deletion course/templates/single-lesson.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<main class="wp-block-group" style="margin-bottom:80px">
<!-- wp:group {"layout":{"inherit":true,"type":"constrained","contentSize":"1000px"}} -->
<div class="wp-block-group">
<!-- wp:post-title {"level":1,"align":"wide","style":{"spacing":{"margin":{"bottom":"2.5rem"}}}} /-->
<!-- wp:post-title {"level":1,"align":"wide"} /-->
</div>
<!-- /wp:group -->

Expand Down