Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a minor issue with theme.json validation error reporting #8065

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix a minor issue with theme.json validation error reporting #8065

merged 1 commit into from
Sep 5, 2024

Conversation

madhusudhand
Copy link
Member

Changes proposed in this Pull Request:

It doesn't exit with code 1 even though there are errors in the output.
It fixes it by checking problems with error type

Related issue(s):

#8039

@madhusudhand madhusudhand self-assigned this Sep 4, 2024
mikachan
mikachan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me 👍

@madhusudhand madhusudhand merged commit 427674b into trunk Sep 5, 2024
2 checks passed
@madhusudhand madhusudhand deleted the theme-validation-fix branch September 5, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees

@madhusudhand madhusudhand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhusudhand @mikachan