Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning on vip export when exporting a MyDumper SQL dump #2130

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

robersongomes
Copy link
Contributor

@robersongomes robersongomes commented Nov 27, 2024

Description

Add a warning on vip export when exporting a MyDumper SQL dump.

Before:
Screenshot_2024-11-27_11-26-11

After:
Screenshot_2024-11-27_11-26-57

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-export-sql.js @yourapp.develop
  4. Verify the warning only shows for sites using MyDumper as the SQL dump tool.

@robersongomes robersongomes requested a review from a team November 27, 2024 14:32
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

sonarcloud bot commented Nov 27, 2024

Copy link
Contributor

@luismulinari luismulinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

LGTM!

@robersongomes robersongomes merged commit 90146fa into trunk Nov 27, 2024
16 checks passed
@robersongomes robersongomes deleted the add/warning-for-mydumper branch November 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants