fix(dev-env) sync: don't slugify domain if it matches the primary domain #2153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2081 we've improved handling of network sites that both utilize subdomains and paths (e.g.
path.site.test
andsite.test/path
) when syncing from a VIP environment.Unfortunately, this introduced an unintended consequence where a site's primary domain would be slugified and prepended to the local env root domain. E.g.
path.site.test
would becomepath-site-test.vip-local.vipdev.lndo.site
This PR addresses the issue and now the search-replace would follow this logic:
primary_domain
=>env_slug.vipdev.lndo.site
convenience_domain
=>env_slug.vipdev.lndo.site
any_other_domain_or_subdomain =>
slugified_any_other_domain_or_subdomain.env_slug.vipdev.lndo.site`Paths are handled respectively. E.g.
primary_domain/my/site/
=>env_slug.vipdev.lndo.site/my/site
Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build
./dist/bin/vip-cookies.js nom