Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-env) sync: don't slugify domain if it matches the primary domain #2153

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

rinatkhaziev
Copy link
Contributor

@rinatkhaziev rinatkhaziev commented Dec 9, 2024

Description

In #2081 we've improved handling of network sites that both utilize subdomains and paths (e.g. path.site.test and site.test/path) when syncing from a VIP environment.

Unfortunately, this introduced an unintended consequence where a site's primary domain would be slugified and prepended to the local env root domain. E.g. path.site.test would become path-site-test.vip-local.vipdev.lndo.site

This PR addresses the issue and now the search-replace would follow this logic:

primary_domain => env_slug.vipdev.lndo.site
convenience_domain => env_slug.vipdev.lndo.site
any_other_domain_or_subdomain => slugified_any_other_domain_or_subdomain.env_slug.vipdev.lndo.site`

Paths are handled respectively. E.g. primary_domain/my/site/ => env_slug.vipdev.lndo.site/my/site

Pull request checklist

New release checklist

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-cookies.js nom
  4. Verify cookies are delicious.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

sonarcloud bot commented Dec 10, 2024

@sjinks sjinks changed the title (feat/dev-env) Sync: don't slugify domain if it matches the primary domain. fix(dev-env) sync: don't slugify domain if it matches the primary domain Dec 10, 2024
@rinatkhaziev rinatkhaziev merged commit e15866b into trunk Dec 10, 2024
17 checks passed
@rinatkhaziev rinatkhaziev deleted the fix/dev-env-sync branch December 10, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants