Filter the font directory to work with the VIP Filesystem

[noahtallen]

Description

WordPress 6.5 introduces the Font Library, which allows customers to upload custom fonts and use them with global styles.

We need to use the new font_dir filter to ensure this will work in the VIP FS, since the default font dir is not writable on our platform.

This ultimately changes the font dir and URL to:

Normal/root site:

• vip://wp-content/uploads/fonts
• https://$site_url/wp-content/uploads/fonts

Network site:

• vip://wp-content/uploads/sites/$network_site_id/fonts
• https://$site_url/$network_site_path/wp-content/uploads/sites/$network_site_id/fonts

Changelog Description

Use a custom font directory for the new Font Library

WordPress 6.5 introduces the Font Library, which allows you to upload and manage your own font files from the site editor. We have used the new font_dir filter to set the font upload directory to wp-content/uploads/fonts to get this feature working with the VIP Filesystem.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally (or has an appropriate fallback).
• This change works and has been tested on a Go sandbox.
• This change has relevant unit tests (if applicable).
• This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

1. Sandbox a VIP site and copy these changes to mu-plugins on that site.
2. From the site editor, choose the global styles sidebar, and then typography.
3. Click the settings icon.
4. Upload a font that you don't have installed on your computer.
5. Use the font for, say, site headings in global styles.
6. Reload the editor, and the new font should display there.
7. View the frontend of the site and the new font should display there.

This recording shows the process:

Screen.Recording.2024-02-21.at.1.56.18.PM.mov

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 28.95%. Comparing base (be19483) to head (6bc5fa2).

Files	Patch %	Lines
files/class-vip-filesystem.php	22.22%	7 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #5265      +/-   ##
=============================================
- Coverage      29.02%   28.95%   -0.08%     
- Complexity      4822     4823       +1     
=============================================
  Files            283      283              
  Lines          20937    20934       -3     
=============================================
- Hits            6077     6061      -16     
- Misses         14860    14873      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[noahtallen]

I think codecov might not realize the test ultimately executes the code via a filter :)

[noahtallen]

We need to follow this PR: WordPress/wordpress-develop#6211

In case the function is renamed/changed. (Or test it by doing the filter instead.)

[peterwilsoncc]

We need to follow this PR: WordPress/wordpress-develop#6211

In case the function is renamed/changed. (Or test it by doing the filter instead.)

I'll try to remember to come back and let you know.

I've been doing some expreiments on my local build and don't intend to change the name of the function or the filter but will confirm.

[noahtallen]

Thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud