Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the command is attempting to write to CSV all at once. #5578

Closed
wants to merge 1 commit into from

Conversation

djalmaaraujo
Copy link

For sites that have a very large number of entries the command can get stalled / killed.

In this update we use a foreach loop to write to the output file incementally.

Please enter the commit message for your changes. Lines starting

Description

Changelog Description

Added

Removed

Fixed

Changed

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

For sites that have a very large number of entries the command can get stalled / killed.

In this update we use a foreach loop to write to the output file incementally.

Please enter the commit message for your changes. Lines starting
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.46%. Comparing base (9f61e13) to head (3389ff7).
Report is 124 commits behind head on develop.

Files Patch % Lines
wp-cli/vip-migrations.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5578      +/-   ##
=============================================
+ Coverage      29.41%   29.46%   +0.04%     
- Complexity      4764     4765       +1     
=============================================
  Files            281      281              
  Lines          20544    20541       -3     
=============================================
+ Hits            6043     6052       +9     
+ Misses         14501    14489      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants