Add notices for when post is locked from publishing

[hanifn]

Description

This PR adds a notice to the top of the editor when publish guard is enabled and the post is not in the last status.

Steps to Test

1. Check out PR.
2. Enable publish guard in VIP Workflow -> Notifications
3. Create or edit a post that's not in Pending review
4. Verify that there is a notice that states the post is blocked from publishing

[ingeniumed]

Just a comment around the wording of the message in the notice, otherwise it looks good to me.

[ingeniumed]

I think the wording of this message could be improved. Something like

This post is locked from publishing, until it reaches pending review status.

might be better?

@alecgeatches or @smithjw1 - wordsmithing help

[smithjw1]

A few thoughts:

Can we hide the publish button? If you can't publish, I don't think we want it there. Maybe "Save" instead. I don't think we need any warning in this case.

If we can do 1, then I would have the warning say: "This post can not be published."

[ingeniumed]

There is some experimentation that Hanif did with css/jQuery, but the best solution we found was taking advantage of lockPostSaving so that the second publish button was disabled via a built-in block editor way

[alecgeatches]

I do like that we have a persistent way to notify the user that the post is locked, but I don't like this visual style. It takes up valuable vertical editing space and I think would be irritating for me if I was using the plugin.

I have a different proposal - what if we use a PluginSidebar as an indicator instead? This would be the same setup that wp-parsely uses:

and also Jetpack:

My thought is that the icon could dynamically show a lock and text when the post is not publishable "Publish Locked", and if you click it, shows the "This post is locked from publishing due to its status." status in the sidebar. If the post is publishable, we should show a different icon or just hide the button entirely. This could be the way to:

• Provide a visual locked indicator near the publish button
• Show information about the locked post
• Avoid taking up editor space if unneeded

[alecgeatches]

To expand on the comment above, it might even be a better UX to rely on the backend publishing guard over lockPostSaving, because it gives a clear indicator that the post isn't publishable right at the point where the user is clicking the button. lockPostSaving feels unclear about what's happening from the user's perspective because there's no feedback, just a disabled button.

[smithjw1]

I like that UX change, if we can't hide (or change the appearance of the publish button).

[ingeniumed]

For context, I had originally suggested this idea for a notice because there wasn't currently a way to add a tooltip to the disabled publish button or tweak the appearance in any way. This would allow some information to be provided at least, that we could always remove when Gutenberg adds something else that useable in it's place or make it configurable.

This bug that I pointed out in #9 will be a blocker in using that backend functionality over this change. From the quick search I did, it seems like this method is recommended for such situations and people do add notices as a way to let users know why it's there. Perhaps making it dismissible might be better?

I'm hesitant on adding another plugin sidebar, given we were talking about how we could unify all those sidebars down the line. That said, I do like that UX change. It'll keep the notice small, and tucked out of the way. It also gives us the added benefit of having a sidebar to use for when we want to add editorial metadata back or any other features for the block editor.

[hanifn]

Closing as the changes in #15 would make this unnecessary