Add payment method logos to card label #10005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +2.62 kB (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
mdmoore
changed the title
mdmoore
requested review from
a team and
gpressutto5
and removed request for
a team
6 tasks
gpressutto5
reviewed
Jan 23, 2025
@gpressutto5 Nice catches! I've made improvements in the responsive handling in 2d30b89 when you have a chance to take another look. |
gpressutto5
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9826
Closes #9660
Changes proposed in this Pull Request
This adds a payment method logos component to the card label on the checkout block. There's another component to this that involves Stripe removing the payment method logo animations from the card number field. For now, this has been implemented on a dev account that we can use for testing. Before this can be merged, we'll need a couple things:
Because payment method animations will be disabled for all WooPayments account, we'll need to ensure we're coordinated with Stripe on the removal. For major release, I think the earliest date would be Feb 5, 2025. However, we could always do a patch release if tighter alignment with Stripe is required.
Testing instructions
Gated Dev account - p1732130572346229/1732125470.634879-slack-C043JN7AJHY
Note: if #9660 hasn't yet been merged, please update the card label text in the browser to read "Cards". This is important because this PR depends on that shorter label to display more card brand logos, especially on mobile.
Blocks Checkout
Classic Checkout
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge