-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E2E NPM scripts #10276
Update E2E NPM scripts #10276
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these updated, Eduardo. Code looks good. The manual tests passed for me. I think this one is good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @eduardoumpierre!
LGTM 👍
Co-authored-by: Eduardo Umpierre <eduardoumpierre@hotmail.com>
…omattic/woocommerce-payments into dev/10240-update-npm-scripts
Co-authored-by: Allie Mims <60988591+allie500@users.noreply.github.com> Co-authored-by: Allie Mims <allie.mims@automattic.com>
…omattic/woocommerce-payments into dev/10240-update-npm-scripts
Fixes #10240
Changes proposed in this Pull Request
This PR aims to update the E2E-related NPM scripts to use Playwright instead of Puppeteer.
Main changes:
test:e2e
now runs the headless Playwright configurationtest:e2e-ci
added — which runs the Playwright for CItest:e2e-dev
renamed totest:e2e-ui
— which runs the UI interactive Playwright configurationtest:e2e-performance
remains as it is, since there is no replacement for it nowtest:e2e-update-snapshots
addedtest:e2e-pw
removedtest:e2e-pw-update-snapshots
removedtest:e2e-pw-ui
removedtest:e2e-pw-ci
removedTesting instructions
npm run test:e2e
— Playwright should be run in headless modenpm run test:e2e-ui
— Playwright should be run in UI modenpm run test:e2e-ci
— Playwright should be run in CI mode (this might fail on your local env)npm run test:e2e-update-snapshots
— Playwright should be run in headless mode with a flag to update snapshotsnpm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge