Prevent potential fatal in multi-currency widget markup getter #10291
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarcosta99
requested review from
a team and
asumaran
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10220.
Changes proposed in this Pull Request
This addresses a potential fatal that might happen in the multi-currency widget markup getter when the widget instance is
null. This fatal is impacting Atomic sites only and based on the logs and this thread p1738351484913529-slack-C01BZUL57SQ, our theory is that this is happening in automated requests only. I haven't been able to reproduce the issue myself.Testing instructions
Setup
Reproduce the issue
develop.return null;early in get_currency_switcher_widget().Fatal error: Uncaught TypeError: spl_object_hash(): Argument #1 ($object) must be of type object, null givenTest: Ensure no fatal error is triggered
Regression test: Ensure currency switcher widget is displayed as expected
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge