Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest API: Move Actors endpoint to use WP_REST_Controller #1257

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Rest API: Move Actors endpoint to use WP_REST_Controller #1257

merged 7 commits into from
Feb 4, 2025

Conversation

obenland
Copy link
Member

@obenland obenland commented Feb 3, 2025 •
edited
Loading

Follow-up to #1146.

Proposed changes:

  • Updates Actors endpoint to extend WP_REST_Controller.
  • Adds unit tests for Actors endpoint.

Other information:

  • Have you written new tests for your changes, if applicable?

@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Feb 3, 2025
@obenland obenland self-assigned this Feb 3, 2025
@obenland obenland force-pushed the update/actors-controller branch from fe49721 to 5aed964 Compare February 3, 2025 11:51
@obenland obenland marked this pull request as ready for review February 4, 2025 08:38
@obenland obenland requested a review from pfefferle February 4, 2025 08:39
@obenland obenland force-pushed the update/actors-controller branch from 926e462 to c9c303e Compare February 4, 2025 08:39
pfefferle
pfefferle requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

@obenland obenland merged commit 33c1fcc into trunk Feb 4, 2025
11 checks passed
@obenland obenland deleted the update/actors-controller branch February 4, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@obenland obenland

Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle