Update Followers endpoint to extend WP_REST_Controller #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenland
added
the
Skip Changelog
pfefferle
requested changes
Feb 5, 2025
| } | ||
|
|
||
| $response['first'] = \add_query_arg( 'page', 1, $response['partOf'] ); | ||
| $response['last'] = \add_query_arg( 'page', \ceil( $response['totalItems'] / $per_page ), $response['partOf'] ); |
There was a problem hiding this comment.
by default (no followers) it shows 0 and loading that page throws an error then. either this should link to min 1 or only show up if $data has more than one page.
|
Now the pages |
pfefferle
previously approved these changes
Feb 5, 2025
|
Could you describe the scenario where you'd expect an error? I'm not quite following |
|
oh sorry! if you have only one page and change the page number in the URL to a way higher page. should we show an error then or simply show an empty items array? |
|
Oh! Core's Posts controller accounts for that, I opted not to bother in the Outbox controller, but happy to reconsider! |
|
I am fine with both... just wanted to bring up the question... |
pfefferle
approved these changes
Feb 5, 2025
Menrath
pushed a commit
to Menrath/wordpress-activitypub
that referenced
this pull request
Feb 6, 2025
* Move file * Update followers endpoint to extend WP_REST_Controlelr * Inherit from Actors_Controller * update schema * Remove debug * Adopt pagination from Outbox Controller Props @pfefferle * Prevent requests that go beyond what's available Props @pfefferle --------- Co-authored-by: Matthias Pfefferle <pfefferle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1146.
Proposed changes:
WP_REST_Controller.Other information: