Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS: Enable GetMetaSingle sniff #907

Merged
merged 2 commits into from
Sep 30, 2024
Merged

PHPCS: Enable GetMetaSingle sniff #907

merged 2 commits into from
Sep 30, 2024

Conversation

obenland
Copy link
Member

@obenland obenland commented Sep 28, 2024 •
edited
Loading

Proposed changes:

  • Added missing parameter definition in post meta functions.
  • Removed sniff exception.

See #905.

@obenland obenland added php Pull requests that update Php code [Type] Janitorial labels Sep 28, 2024
@obenland obenland self-assigned this Sep 28, 2024
pfefferle
pfefferle previously approved these changes Sep 29, 2024
View reviewed changes
@pfefferle pfefferle merged commit f40905d into trunk Sep 30, 2024
21 checks passed
@pfefferle pfefferle deleted the fix/GetMetaSingle-sniff branch September 30, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

@mattwiebe mattwiebe Awaiting requested review from mattwiebe

Assignees

@obenland obenland

Labels
php Pull requests that update Php code [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle