-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPCS: Enable UnusedFunctionParameter sniff #911
Conversation
won't that result in at least PHP warnings, because the functions are always called with these params, if they are used or not? |
Yeah, maybe this needs a different approach |
@pfefferle Can you double-check? I think they should just be ignored. I've also not been able to generate a warning in my testing. |
OK, the shortcode API says:
|
Proposed changes:
at_title
shortcode to make sure that still works.See #905.