Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title to content if post is a Note #958

Merged
merged 18 commits into from
Oct 31, 2024
Merged

Add title to content if post is a Note #958

merged 18 commits into from
Oct 31, 2024

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Oct 25, 2024 •
edited
Loading

I took the opportunity to also simplify the code quite a bit.

Proposed changes:

  • Change default-type to WordPress
  • Add title to the content if Activity-Type === Note
  • Remove all pre-defined template options
Screenshot 2024-10-25 at 20 17 59

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@pfefferle pfefferle marked this pull request as draft October 25, 2024 18:16
@pfefferle pfefferle marked this pull request as ready for review October 28, 2024 15:38
@pfefferle pfefferle self-assigned this Oct 28, 2024
mattwiebe
mattwiebe reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really love this. One question about the default template.

activitypub.php Outdated Show resolved Hide resolved
@pfefferle
Copy link
Member Author

@mattwiebe I removed the shortlink!

mattwiebe
mattwiebe approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go!

@pfefferle pfefferle merged commit 8a227c7 into trunk Oct 31, 2024
21 checks passed
@pfefferle pfefferle deleted the add/title-to-content branch October 31, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiebe mattwiebe mattwiebe approved these changes

Assignees

@pfefferle pfefferle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfefferle @mattwiebe