Work around race condition when publishing local only posts

[pfefferle]

It seems that the meta-information might not always be stored when saving a new post.

See discussion here: https://sueden.social/@freuwesen/113378039196820044 (it is in german but mastodon can translate).

Proposed changes:

• clear audience fields, so that post will not be listed in any timeline when accidentally shared
• check a second time, right before federating it

[mattwiebe]

Could we also maybe add a slight delay to the scheduler to give more time for the race condition to resolve?

[pfefferle]

Could we also maybe add a slight delay to the scheduler to give more time for the race condition to resolve?

with a "hacky" sleep(2)?

do have an idea if there is a better hook to use?

maybe #668 ???

[mattwiebe]

Could we also maybe add a slight delay to the scheduler to give more time for the race condition to resolve?

with a "hacky" sleep(2)?

do have an idea if there is a better hook to use?

maybe #668 ???

I'm thinking about where we schedule the cron job here. When the first arg is time() it's a near-instant cron job that is possibly running out ahead of the process that's trying to update postmeta to set private visibility. So we add 30 seconds:

\wp_schedule_single_event( \time() + 30, $hook, $args );

Or even less, maybe 5-10, something like that. Just gives all the saving processes a little more time to settle before blasting out the post.

[pfefferle]

I See! Makes sense!

[pfefferle]

@mattwiebe added all changes!