Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comment_previously_approved setting #962

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Support comment_previously_approved setting #962

merged 8 commits into from
Nov 6, 2024

Conversation

pfefferle
Copy link
Member

No description provided.

@pfefferle pfefferle marked this pull request as draft October 29, 2024 15:03
@pfefferle pfefferle marked this pull request as ready for review November 4, 2024 09:02
mattwiebe
mattwiebe reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read this correctly, what we're doing here is seeing if a fediverse commenter has previously had an approved comment and if so, to approve future comments from them?

@pfefferle
Copy link
Member Author

@mattwiebe exactly!

mattwiebe
mattwiebe approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement.

@pfefferle pfefferle merged commit 3034df5 into trunk Nov 6, 2024
21 checks passed
@pfefferle pfefferle deleted the improve/comment_previously_approved branch November 6, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiebe mattwiebe mattwiebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfefferle @mattwiebe