Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename uniffi_bindgen crate to wp_uniffi_bindgen and update uniffi to 0.27.0 #51

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

oguzkocer
Copy link
Contributor

We have the following warning when we run cargo doc:

warning: output filename collision.
The lib target uniffi_bindgen in package uniffi_bindgen v0.26.1 has the same output filename as the bin target uniffi_bindgen in package uniffi_bindgen v0.1.0 (./wordpress-rs/uniffi_bindgen).
Colliding filename is: ./wordpress-rs/target/doc/uniffi_bindgen/index.html
The targets should have unique names.
This is a known bug where multiple crates with the same name use
the same path; see rust-lang/cargo#6313.

In order to address that, I've renamed our crate to wp_uniffi_bindgen and updated the Makefile and the Gradle config accordingly.

While making the changes, I noticed that uniffi had a new release, so I updated it to 0.27.0 which required a few minor updates in the Android project. Also, there was a breaking change in project's trunk related to authentication token, so I've updated that in Android as well.

@oguzkocer oguzkocer merged commit 3b71b4a into trunk Mar 27, 2024
19 checks passed
@oguzkocer oguzkocer deleted the rename_uniffi_bindgen_crate branch March 27, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants