Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Deprecate VerticalNavItem, move functionality to existing or new component #142

Closed
hoverduck opened this issue Nov 18, 2015 · 1 comment

Comments

@hoverduck
Copy link
Contributor

Now that <Card /> wraps itself in an anchor and includes a chevron if passed the href prop, we should deprecate <VerticalNavItem />. There is still some functionality in <VerticalNavItem /> that will need to be included elsewhere:

<Card /> doesn't have a placeholder state like <VerticalNavItem />, so it isn't as simple as simply replacing all of the instances of the latter with the former in this component. It also doesn't support an external link icon

The logic for using the external link Gridicon should live in <Card />, and we may need a new component for the placeholder state that <VerticalNavItem /> currently provides, because <Card /> probably shouldn't be opinionated about the structure of its child content.

I think any placeholder state should be created by the developer for their specific uses. If we have a generic placeholder it sort of defeats the purpose and becomes just a glorified spinner :)

VerticalNavItem has a specific style (a single line with a Gridicon on the right) that is used in domains and purchases, so creating a shared component somewhere to replicate the placeholder state (below) for this style probably makes sense if we're going to continue using it. We only use it in one component in each domains/purchases right now, so maybe we should just duplicate the CSS, or create a separate component for each section?

image

@gziolo
Copy link
Member

gziolo commented Nov 19, 2015

We also use it in Domain Management section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants