Components: Deprecate VerticalNavItem
, move functionality to existing or new component
#142
Labels
VerticalNavItem
, move functionality to existing or new component
#142
Now that
<Card />
wraps itself in an anchor and includes a chevron if passed thehref
prop, we should deprecate<VerticalNavItem />
. There is still some functionality in<VerticalNavItem />
that will need to be included elsewhere:The logic for using the external link Gridicon should live in
<Card />
, and we may need a new component for the placeholder state that<VerticalNavItem />
currently provides, because<Card />
probably shouldn't be opinionated about the structure of its child content.I think any placeholder state should be created by the developer for their specific uses. If we have a generic placeholder it sort of defeats the purpose and becomes just a glorified spinner :)
VerticalNavItem
has a specific style (a single line with a Gridicon on the right) that is used in domains and purchases, so creating a shared component somewhere to replicate the placeholder state (below) for this style probably makes sense if we're going to continue using it. We only use it in one component in each domains/purchases right now, so maybe we should just duplicate the CSS, or create a separate component for each section?The text was updated successfully, but these errors were encountered: