Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Sheet live preview #3162

Closed
3 of 4 tasks
ehg opened this issue Feb 8, 2016 · 2 comments
Closed
3 of 4 tasks

Themes: Sheet live preview #3162

ehg opened this issue Feb 8, 2016 · 2 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Themes: Showcase ...

Comments

@ehg
Copy link
Member

ehg commented Feb 8, 2016 •
edited by seear
Loading

We should open a preview on the theme sheet page.

TODO:

  • Add preview link
  • When preview link is clicked, open a WebPreview overlay with the theme's demo site
  • Buttons: "Pick this design" | "Try & Customize"
  • Look into remaining problems on mobile safari [1]

UI:
screen shot 2016-03-02 at 12 51 01

For mobile:
screen shot 2016-05-23 at 11 45 38
@ehg ehg added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature Group] Appearance & Themes Features related to the appearance of sites. labels Feb 8, 2016
@ehg ehg added this to the Themes: Showcase M4-ThemeSheets milestone Feb 8, 2016
@folletto
Copy link
Contributor

folletto commented Mar 3, 2016

Design reference:

tshowcase-m4-m7-livepreview-i3

The button changes depending if the user is logged in or logged out.

@seear seear mentioned this issue May 20, 2016
Merged
seear added a commit that referenced this issue May 31, 2016
@seear
Themes: Add live preview to sheet (#5482)
a3c4c3f 
Add the Live Preview overlay to the Theme Sheet page.
Addresses #3162
@seear
Copy link
Contributor

seear commented May 31, 2016

Done #5482

@seear seear closed this as completed May 31, 2016
@snyk-bot snyk-bot mentioned this issue Jun 13, 2022
Open
@awaisab172 awaisab172 mentioned this issue Apr 30, 2023
Open
@awaisab172 awaisab172 mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Themes: Showcase M4-ThemeSheets
Development

No branches or pull requests
3 participants
@folletto @ehg @seear