Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav unification: port over Calypso exclusive color schemes to wp-admin #47040

Closed
frontdevde opened this issue Nov 3, 2020 · 3 comments
Closed
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.

Comments

@frontdevde
Copy link
Contributor

frontdevde commented Nov 3, 2020

This issue is part of the effort of combining color schemes in the Nav unification project.
For the approved direction please see #45675 (comment).

https://github.com/WordPress/WordPress/blob/e569358678dd1d3480740e451d546bf8b5ad8101/wp-includes/general-template.php#L4514-L4524

Reference Issues

@frontdevde frontdevde added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 3, 2020
@mreishus
Copy link
Contributor

mreishus commented Nov 10, 2020

Themes Need Changes In Calypso, Too

Heads up; in addition to porting them to wp-admin, all of these schemes need changes in calypso, too. If you turn on one of these schemes in calypso, then turn on the nav-unification flag, you still see the old wp-admin colorscheme in calypso.

Changes Needed

  • The scope of the scheme's current variable settings needs to be expanded to include .is-nav-unification.
  • Some additional color variables that only exist in calypso nav unification need to be set. These are submenu colors which exist in wp-admin and nav unification, but not regular calypso.

Example

It's probably best to do these changes at the same time the scheme is ported to wp-admin so we can be sure they match 1:1.
I can do one as an example to show what it would look like in a draft PR.

@frontdevde
Copy link
Contributor Author

@frontdevde frontdevde changed the title Nav unification: Add the necessary wp-admin styles to support all color schemes available in Calypso Nav unification: port over Calypso exclusive color schemes to wp-admin Nov 26, 2020
@frontdevde
Copy link
Contributor Author

Closed by Automattic/jetpack#17828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

No branches or pull requests

2 participants