Nav unification: consolidate color-sidebar-menu-hover and -text variable

[mreishus]

Background

This is relatively straightforward and an easy change with no downsides, in my opinion.

• This is considering the color of text when hovering over sidebar items.
• Before we started the nav-unification project, calypso color schemes used color-sidebar-menu-hover-text.
• When we first added nav unification styles, we defined two variables, with the same color value:
  • color-sidebar-menu-hover-text
    • This matches the calypso variable, but wasn't used anywhere.
  • color-sidebar-menu-hover
    • This was a new variable that only existed in nav unification.

Changes proposed in this Pull Request

• Change all references of color-sidebar-menu-hover to color-sidebar-menu-hover-text.
• Remove all theme definitions of color-sidebar-menu-hover.
  • The existing definitions of color-sidebar-menu-hover-text will work in their place. All themes had the same values for both.

Benefits

• One less variable
• Less changes needed to calypso schemes when porting to nav-unification calypso.

Testing instructions

Visit calypso with nav unification turned on, http://calypso.localhost:3000/?flags=nav-unification. Hovering text should still work (in most themes it's white, but it's blue in the default nav unification theme).

Reference Issues

• Main Issue Nav Unification - Main Issue #45435
  • Color Schemes Issue + Direction Nav Unification: Color Schemes #45675
    • Add the necessary wp-admin styles to support all color schemes available in Calypso Nav unification: port over Calypso exclusive color schemes to wp-admin #47040
      • Nav unification: Example of extending sakura to work on nav-unification Nav unification: Example of extending sakura to work on nav-unification #47292

[matticbot]

Test live: https://calypso.live/?branch=fix/consolidate-nav-unification-vars-1

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[frontdevde]

Nice catch! Tested as per testing instructions. LGMT 👍