Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Toolkit CI: Run phpunit tests fails #47255

Closed
jeyip opened this issue Nov 9, 2020 · 1 comment · Fixed by #47489
Closed

Editing Toolkit CI: Run phpunit tests fails #47255

jeyip opened this issue Nov 9, 2020 · 1 comment · Fixed by #47489
Assignees
Labels
[Pri] Normal Schedule for the next available opportuinity. [Type] Bug

Comments

@jeyip
Copy link
Contributor

jeyip commented Nov 9, 2020

Steps to reproduce

  1. Modify code in the wp-calypso/apps/editing-toolkit directory (I commented out lines 19 and 20 in wp-calypso/apps/editing-toolkit/editing-toolkit-plugin/dotcom-fse/blocks/post-content/edit.js
  2. Create a test branch and push the changes to Github
  3. Verify that the Github CI Job for Run phpunit tests fails

What I expected

The php unit tests CI job for the editing toolkit should pass without issue when I haven't made modifications to PHP files.

What happened instead

The CI job failed for unrelated configuration issues with nodegit

Screenshot / Video

Source: https://github.com/Automattic/wp-calypso/runs/1376351946?check_suite_focus=true
Screen Shot 2020-11-09 at 2 18 36 PM

Context / Source

p1604956506439800-slack-C02DQP0FP

Potential Causes

"node-git was recently updated in the wp-env package in Gutenberg, but I doubt that has made it to npm yet. Maybe that patch in Gutenberg is meant to fix this issue: WordPress/gutenberg#26712"

@jeyip jeyip added [Pri] Low Address when resources are available. [Type] Bug [Pri] Normal Schedule for the next available opportuinity. and removed [Pri] Low Address when resources are available. labels Nov 9, 2020
@jeyip
Copy link
Contributor Author

jeyip commented Nov 9, 2020

I've confirmed this bug and am assigning a priority of normal. I didn't assign a low priority because, although this isn't causing any user facing issues, the longer automated tests continue to fail, the less credibility they hold for other developers. Given enough time, other devs become more inclined to ignore some of these automated checks altogether, causing actual regressions to be ignored as well.

We should fix this within a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Schedule for the next available opportuinity. [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants