Update nodegit to 0.27.0 in @wordpress/env #26712
Conversation
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
fix/26660-nodegit
branch
from
6a18ca8 to
2b84cf8
Compare
There was a problem hiding this comment.
I rebased this branch and included local changes applied to package-lock.json to resolve the issues raised by the CI job.
I also removed the manual version bump to the @wordpress/env package. Lerna will take care of it during publishing.
I can confirm that npm i works correctly with Node v14.
| @@ -39,7 +39,7 @@ | |||
| "got": "^10.7.0", | |||
| "inquirer": "^7.1.0", | |||
| "js-yaml": "^3.13.1", | |||
| "nodegit": "^0.26.2", | |||
| "nodegit": "^0.27.0", | |||
| "ora": "^4.0.2", | |||
There was a problem hiding this comment.
Should we add a note in the CHANGELOG file? Technically, it means we didn't have proper support for Node v14 before.
There was a problem hiding this comment.
My thought is we could create a single item to roll under a set of changes to support v14, for example if we're ready to update workflows and anywhere else. 9.3 just went out, so we can plan it all under 9.4
There was a problem hiding this comment.
We won't publish it to npm until WordPress 5.6 is released so we can do it in steps :)
There was a problem hiding this comment.
Is there a reason to hold on publishing wp-env until 5.6? it's a dev dependency.
There was a problem hiding this comment.
We could cherry-pick commits with dev tools changes and publish to npm earlier, but someone would have to volunteer 😄 There are no other blockers.
There was a problem hiding this comment.
I'm still blocked by other stuff, if this proves to be the only thing preventing me from using node 14 + npm 7, I will update.
There was a problem hiding this comment.
We could cherry-pick commits with dev tools changes and publish to npm earlier, but someone would have to volunteer 😄 There are no other blockers.
How would I go about doing this? It would be helpful to release all of the recent wp-env changes!
|
Ah thanks for the fixes, I bumped the version because it initially wasn't working with the change. It took a bit to realize the issue was in the package-lock.json and forgot to go back and restore. |
Description
To support Node LTS 14.15.0 we need to upgrade nodegit to 0.27.0.
The previous version does not have binaries pre-built for the new LTS, making npm install fail (or complicated to build from source for everyone)
Related to #26660
How has this been tested?
Try to run
npm installusing Node LTS 14.15.0You should see an error about nodegit prebuilt binary not found
Apply patch and run
npm installand it should all worknpm run buildafter install and confirm app still builds and works as expected, in particular testing wp-envTypes of changes