Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused Launch: Ensure selected domain is always shown to the user in the Domain Details View #47512

Closed
3 tasks done
tjcafferkey opened this issue Nov 17, 2020 · 2 comments · Fixed by #47633
Closed
3 tasks done

Comments

@tjcafferkey
Copy link
Contributor

tjcafferkey commented Nov 17, 2020

What

When a user enters their site title (e.g. Toms Photography Tips) in the Summary View, selects a suggested domain based on this site title in the Domain Details View (e.g. tomsphotographytips.blog). Then decides to change the title of their site (e.g. Toms Fishing Tips) triggering a regeneration of completely new suggested domains related to fishing.

We need to ensure that when they then revisit the Domain Details view we highlight their initially selected domain (tomsphotographytips.blog) after the new list of suggested domains, even though it may be now seemingly unrelated to their suggestions.

Why

  • We need to always show the user their currently selected domain when they're viewing suggested domains. This will prevent users accidentally registering domains that may not be suitable, or related to the topic of their new website.

Acceptance Criteria

  • Should the user navigate to the Domain Details view without having already selected a domain, the Domain Picker in the Details View should show a list of suggestions based on the search query
  • Should the user navigate to the Domain Details view while already having selected a domain, the Domain Picker in the Details view should highlight the currently selected domain if it is returned in the list of suggested domains
  • Should the user navigate to the Domain Details view while already having selected a domain, the Domain Picker in the Details view should append (and highlight) the currently selected domain as an additional option, if the currently selected domain is not in the returned list of suggested domains

Considerations

  • This issue may require changes to the domain picker package, we need to ensure this doesn't negatively impact the areas it's used in the following:
    • Focused Launch
    • Step-by-step Launch
    • New onboarding
@tjcafferkey tjcafferkey added this to the Focused Launch: MVP milestone Nov 17, 2020
@ciampo ciampo changed the title Focused Launch: Ensure selected domain is present in suggested domains list Focused Launch: Ensure selected domain is always shown to the user Nov 17, 2020
@tjcafferkey tjcafferkey changed the title Focused Launch: Ensure selected domain is always shown to the user Focused Launch: Ensure selected domain is always shown to the user in the Domain Details View Nov 18, 2020
@tjcafferkey
Copy link
Contributor Author

@ollierozdarz just seen your comment here about no domains (or plans) being pre-selected for the user. I am assuming that is the case for if this is the first time the user views the focused launch modal.

There are some other considerations outlined in this issue that me and @ciampo, would you mind reading the issue above and let me know if this sounds right to you?

@tjcafferkey tjcafferkey self-assigned this Nov 18, 2020
@ollierozdarz
Copy link

@tjcafferkey acceptance criteria sounds right to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants