Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused Launch: Ensure selected domain is always shown to the user in the Summary View #47540

Closed
3 of 5 tasks
tjcafferkey opened this issue Nov 18, 2020 · 2 comments · Fixed by #47633
Closed
3 of 5 tasks
Assignees
Labels
Feature [Launch] Launching a site from Coming Soon to Published. [Type] Task

Comments

@tjcafferkey
Copy link
Contributor

tjcafferkey commented Nov 18, 2020

Important: Potentially blocked by #47512 as both detail with changes to the <DomainPicker /> which will be used in both solutions.

What

There are a few scenarios under which the user can visit the Summary view while having selected a domain that is not part of the 3 suggested items in the Domain Step:

  • Scenario A. The user enters the site title, picks a domain from the Domain Picker in the Domain step, and then changes the site title again. The Domain step shows new recommendations, and the currently selected domain is not shown to the user anymore.
  • Scenario B. The user visits the Domain Details view, picks a domain that is not part of the initial suggestions in the Summary view. The user navigates back to the Summary view, and the currently selected domain is not shown to the user.

Why

We need to always show the currently selected domain to the user in the Summary view, while keeping the top paid suggestions always at the top and free suggestion always at the bottom.

Acceptance Criteria

Screen Shot 2020-11-13 at 9 40 53 am

Considerations

For added context, if the user hasn't made an explicit selection yet in the context of the launch flow, the domain step should not pre-select any domain (as specc'd and discussed separately in #47458)

  • This issue may require changes to the domain picker package, we need to ensure this doesn't negatively impact the areas it's used in the following:
    • Focused Launch
    • Step-by-step Launch
    • New onboarding
@tjcafferkey tjcafferkey added [Type] Task Feature [Launch] Launching a site from Coming Soon to Published. labels Nov 18, 2020
@tjcafferkey tjcafferkey added this to the Focused Launch: MVP milestone Nov 18, 2020
@tjcafferkey
Copy link
Contributor Author

@ollierozdarz just seen your comment here about no domains (or plans) being pre-selected for the user. I am assuming that is the case for if this is the first time the user views the focused launch modal.

There are some other considerations outlined in this issue that me and @ciampo, would you mind reading the issue above and let me know if this sounds right to you?

@ollierozdarz
Copy link

Hey @tjcafferkey, the acceptance criteria for this one looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature [Launch] Launching a site from Coming Soon to Published. [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants