Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Verification: Make notices better/more prominent #93895

Open
taipeicoder opened this issue Aug 26, 2024 · 10 comments
Open

Email Verification: Make notices better/more prominent #93895

taipeicoder opened this issue Aug 26, 2024 · 10 comments
Assignees
Labels
[Pri] Normal [Type] Enhancement [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com

Comments

@taipeicoder
Copy link
Contributor

taipeicoder commented Aug 26, 2024

Description

See context.

Several features in WP.com are blocked if the account email has not been verified, and we display notices accordingly.

Image

The notice text is truncated here.
Image

There is also a scenario where the user can purchase a domain during onboarding, but then the experience breaks since they would need to verify their email.

Image

@javierarce javierarce added the [Status] Needs Design Add this to PRs that need input from Design label Aug 26, 2024
@javierarce
Copy link

For the first two issues you mentioned, I think it's good that the message appears in context (obviously, in the case of the notice inside the avatar, the position is terrible), but there should be a global notice at the top.

For the third issue, the problem isn't specific to that screen. The walkthrough reveals that the problem is that we don't have (or at least aren't displaying) global notifications.

PS: I'd rename this issue to something like: "Implement global notifications for critical messages"

@davemart-in
Copy link
Contributor

Moving this to "Needs design"

@javierarce javierarce self-assigned this Aug 27, 2024
@mmtr
Copy link
Member

mmtr commented Sep 4, 2024

@javierarce do you have any update on this?

@javierarce
Copy link

I have an answer ready, but since there are related tasks that go beyond the scope of this issue and require some general context, I'm going to publish everything in a P2.

@javierarce
Copy link

Here's the P2 post I mentioned on my previous message: p9Jlb4-dYD-p2

@javierarce
Copy link

javierarce commented Sep 5, 2024

After reviewing the feedback on p9Jlb4-dYD-p2, we have an accepted design proposal. Here are the screens that are relevant to this issue:

image
image
image

Here's a link to the updated Figma file: wCm5Tzb7JBaG4WNowWbjES-fi-5057_13109

PS: I'll open a new issue to handle the removal of the email change notification (wCm5Tzb7JBaG4WNowWbjES-fi-5057_20764)

@mmtr mmtr added [Type] Enhancement [Pri] Normal [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com and removed [Status] Needs Design Add this to PRs that need input from Design labels Sep 5, 2024
@Addison-Stavlo Addison-Stavlo self-assigned this Sep 17, 2024
@Addison-Stavlo
Copy link
Contributor

One PR for the dialog itself here: #94629

@Addison-Stavlo
Copy link
Contributor

@javierarce For the "Verify Email" button on the right side of the notice:
Screenshot 2024-09-17 at 2 19 57 PM

Does this:

  • navigate to /me/account
  • open the modal
  • resend the email
  • other?

@javierarce
Copy link

@Addison-Stavlo it should open the modal.

@Addison-Stavlo
Copy link
Contributor

it should open the modal.

Thanks for clarifying. That sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Enhancement [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com
Projects
None yet
Development

No branches or pull requests

5 participants