Update email verification items - remove old notices, add banner, update copies and success messages. #94683

Addison-Stavlo · 2024-09-18T19:08:25Z

Related to # #93895 and #94247

Proposed Changes

Removes the email not verified notice and email pending change notice that were previously underneath the input and moves these concerns into the input's explanation text, a new banner, and new success message on successful email change. The various forms of the explanation text are shown immediately below:
- General case (unchanged).
- Email not verified case:
- Email pending change case:
Adds a new email verification banner at the top of /me and /me/account that opens the email verification dialog when clicked.

The email verification dialog has been updated to close on route change, and to send an event to signal focus/scroll behavior on the email input if on /me/account. It has also been updated to allow resending an email for pending email change, as it was previously only set up for verification email.
- updated to close on route change - previously this dialog was not shown /me/account, so clicking the link to /me/account would close the dialog since its parent controller was no longer rendered. Now that we have the new verification banner controlling the dialog which is also shown on /me/account, the parent controller does not dismount and close the dialog. Therefore we ensure it closes on route change.
- When on /me/account, the link to change the email that would generally lead to /me/account now focuses and scrolls the email input (or cancel pending change button if applicable).
Adds a SuccessNotice when the email is updated, mentioning an email was sent to the new address.
- This has been added on both /me/account as well as /me/security/account-email
- On /me/account, the success notice copy is conditional to the changes made (other settings only, email only, or both email and other settings).
  - Only other settings changed
  - Only email changed
  - Both email and other settings changed
Adds a success notice when the user is redirected to /me/account after confirming a pending email change. This contains the previous information about updating domain information if necessary and a the same link to updating domains contact info that was previously in the notice.
- Also updates the middleware that redirects legacy route /settings/account to /me/account to include the ?new_email_result=1 param if it exists, and other middleware will check for this param, remove it, and add the corresponding notice.
POTENTIAL FOLLOW-UPs
- Some basic unit tests. We removed some unit tests for the one of the now unused notices that verified it does not show up unless the email is unverified. We should at the very least add a unit test for the banner to ensure it only shows up if unverified or if pending change.
- We may want to update the banner component to support an isCritical or isWarning type case. Currently it is set to inherit interface colors (or maybe jetpack colors), and we override styles for our specific use to get the red. If this is intended to be used for more warnings in the future, we should move those styles into the banner component and allow them to be enabled with a prop.
  BEFORE

AFTER
As shown above in description items.

Why are these changes being made?

as expressed on issues Email Verification: Make notices better/more prominent #93895 and Email Verification: Improve the UI of the Pending Email Change banner #94247
The notices were not prominent enough (this banner approach allows extending them to other pages like /me).
The notices were piled on redundant in some cases like unverified + email pending change.
There was no success notice for a successful email change confirmation.

Testing Instructions

Create a couple test email addresses, create a new account on WordPress.com and do not verify the email. I think logging in with google automatically verifies (?), so I used the "continue with email" create account option.
Load this branch of calypso,
go to /me/account.
Verify the text underneath the input updates to reflect the email is not verified.
Verify the new banner appears at the top of /me and /me/account.
On /me, verify clicking the banner opens the dialog. Verify the "change" button on the dialog redirects to /me/account and closes the dialog.
- Bonus - verify the "resend email" button in the dialog still works here and sends an email to your inbox.
On /me/account, verify clicking the banner opens the dialog. Verify the "change" button closes the dialog and focus/scrolls the input for use.
Verify your email via the link in the email message.
Change your email on /me/account. When you submit you should see a success notice mentioning the email address to check.

Later test this along with other settings like changing your primary site, as well as just changing the primary site with no email change. Verify the success notice updates contextually to what has changed as described in the description above.

The input should now be locked, and the copy underneath should have changed. Verify there is a link/button to cancel the pending email change.
Re-open the dialog from the banner. Click "resend email" and verify you get another copy of the pending change email in your inbox.
Re-open the dialog from the banner. Verify clicking "change" now focuses the cancel pending change button.
Re-open the dialog from the banner.
Click the button to cancel the pending change. Verify the input is usable and shows the old email address.
Go to */settings/account?new_email_result=1. Verify this redirects to /me/account, they query param is gone, and there is a success notice with a link to domains.
- We can not test email -> link click to confirm change -> into calypso here easily since these links are handled through and redirected in production. So instead we test where a successful email change would land at */settings/account?new_email_result=1.
Verify that once email is verified and there is no pending change, there is no verification banner shown and that the message under the input does not note a need for verification or a pending change.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2024-09-18T19:08:38Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-120985

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-120985&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-120985&env=a8c-for-agencies

matticbot · 2024-09-18T19:19:32Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~83 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +396 B  (+0.0%)     +124 B  (+0.0%)
entry-main                  +262 B  (+0.0%)     +117 B  (+0.0%)
entry-subscriptions          -56 B  (-0.0%)      -32 B  (-0.0%)
entry-login                  -56 B  (-0.0%)      -73 B  (-0.0%)
entry-domains-landing        -56 B  (-0.0%)      -32 B  (-0.0%)
entry-browsehappy            -56 B  (-0.0%)      -32 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~83305 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
me                                     +44865 B  (+6.3%)   +15510 B  (+7.7%)
account-close                          +44865 B  (+6.1%)   +15510 B  (+7.5%)
site-blocks                            +44772 B  (+5.9%)   +14851 B  (+6.9%)
privacy                                +44772 B  (+6.1%)   +14795 B  (+7.0%)
help                                   +44772 B  (+6.0%)   +14795 B  (+7.0%)
developer                              +44772 B  (+6.0%)   +14840 B  (+7.0%)
notification-settings                  +43625 B  (+5.2%)   +14518 B  (+6.2%)
security                               +37031 B  (+3.9%)   +11957 B  (+4.5%)
account                                +34922 B  (+3.7%)   +11742 B  (+4.3%)
purchases                              +10002 B  (+0.5%)    +2819 B  (+0.5%)
settings                                 +848 B  (+0.1%)     +911 B  (+0.3%)
update-design-flow                       +451 B  (+0.0%)     +521 B  (+0.2%)
link-in-bio-tld-flow                     +405 B  (+0.0%)     +144 B  (+0.0%)
email                                    +400 B  (+0.1%)     +506 B  (+0.2%)
settings-performance                     +335 B  (+0.1%)    -1609 B  (-1.0%)
signup                                   +329 B  (+0.1%)       +5 B  (+0.0%)
settings-newsletter                      -177 B  (-0.0%)     -817 B  (-0.5%)
posts-custom                             -142 B  (-0.0%)     -178 B  (-0.1%)
posts                                    -142 B  (-0.0%)     -178 B  (-0.1%)
people                                    -84 B  (-0.0%)     -208 B  (-0.1%)
with-theme-assembler-flow                 +46 B  (+0.1%)      +13 B  (+0.1%)
update-options-flow                       +46 B  (+0.1%)      +12 B  (+0.2%)
trial-wooexpress-flow                     +46 B  (+0.1%)      +13 B  (+0.2%)
tailored-ecommerce-flow                   +46 B  (+0.1%)      +12 B  (+0.2%)
start-writing-flow                        +46 B  (+0.1%)      +11 B  (+0.1%)
site-setup-wg                             +46 B  (+0.0%)      +14 B  (+0.1%)
site-setup-flow                           +46 B  (+0.1%)      +14 B  (+0.1%)
site-migration-flow                       +46 B  (+0.1%)      +11 B  (+0.1%)
reblogging-flow                           +46 B  (+0.8%)      +15 B  (+0.8%)
readymade-template-flow                   +46 B  (+0.0%)      +15 B  (+0.0%)
onboarding-flow                           +46 B  (+0.6%)      +20 B  (+0.9%)
newsletter-flow                           +46 B  (+0.2%)      +12 B  (+0.1%)
new-hosted-site-flow-user-included        +46 B  (+0.8%)      +22 B  (+1.1%)
new-hosted-site-flow                      +46 B  (+0.8%)      +20 B  (+1.0%)
migration-signup                          +46 B  (+0.1%)      +12 B  (+0.2%)
migration-flow                            +46 B  (+0.1%)      +12 B  (+0.1%)
link-in-bio-flow                          +46 B  (+0.3%)      +10 B  (+0.2%)
jetpack-app                               +46 B  (+0.0%)      +41 B  (+0.0%)
import-flow                               +46 B  (+0.1%)      +12 B  (+0.1%)
hosted-site-migration-flow                +46 B  (+0.1%)      +11 B  (+0.1%)
free-post-setup-flow                      +46 B  (+0.1%)      +12 B  (+0.2%)
free-flow                                 +46 B  (+0.1%)      +12 B  (+0.1%)
entrepreneur-flow                         +46 B  (+0.0%)      +11 B  (+0.0%)
design-first-flow                         +46 B  (+0.1%)      +11 B  (+0.1%)
connect-domain                            +46 B  (+0.2%)      +18 B  (+0.3%)
assembler-first-flow                      +46 B  (+0.1%)      +12 B  (+0.1%)
ai-assembler-flow                         +46 B  (+0.1%)      +14 B  (+0.1%)
write-flow                                -39 B  (-0.0%)      -18 B  (-0.0%)
woocommerce-installation                  -39 B  (-0.0%)      -17 B  (-0.0%)
woocommerce                               -39 B  (-0.0%)      -17 B  (-0.0%)
videopress-flow                           -39 B  (-0.0%)      -17 B  (-0.0%)
themes                                    -39 B  (-0.0%)      -17 B  (-0.0%)
theme                                     -39 B  (-0.0%)      -17 B  (-0.0%)
subscribers                               -39 B  (-0.0%)      -17 B  (-0.0%)
stats                                     -39 B  (-0.0%)      -17 B  (-0.0%)
settings-writing                          -39 B  (-0.0%)      -17 B  (-0.0%)
settings-security                         -39 B  (-0.0%)      -17 B  (-0.0%)
settings-reading                          -39 B  (-0.0%)      -17 B  (-0.0%)
settings-podcast                          -39 B  (-0.0%)      -17 B  (-0.0%)
settings-jetpack                          -39 B  (-0.0%)      -17 B  (-0.0%)
sensei-flow                               -39 B  (-0.0%)      -17 B  (-0.0%)
scan                                      -39 B  (-0.0%)      +58 B  (+0.0%)
promote-post-i2                           -39 B  (-0.0%)      -17 B  (-0.0%)
preview                                   -39 B  (-0.0%)      -17 B  (-0.0%)
patterns                                  -39 B  (-0.0%)       -9 B  (-0.0%)
pages                                     -39 B  (-0.0%)      -17 B  (-0.0%)
migrate                                   -39 B  (-0.0%)      -17 B  (-0.0%)
media                                     -39 B  (-0.0%)       -9 B  (-0.0%)
marketplace                               -39 B  (-0.0%)      -17 B  (-0.0%)
marketing                                 -39 B  (-0.0%)     -443 B  (-0.2%)
jetpack-social                            -39 B  (-0.0%)     +372 B  (+0.2%)
jetpack-search                            -39 B  (-0.0%)      +77 B  (+0.0%)
jetpack-connect                           -39 B  (-0.0%)      -78 B  (-0.0%)
jetpack-cloud-settings                    -39 B  (-0.0%)      -17 B  (-0.0%)
jetpack-cloud-pricing                     -39 B  (-0.0%)       -4 B  (-0.0%)
jetpack-cloud-overview                    -39 B  (-0.0%)      -17 B  (-0.0%)
jetpack-cloud-features-comparison         -39 B  (-0.0%)      -15 B  (-0.0%)
jetpack-cloud-agency-sites-v2             -39 B  (-0.0%)      +66 B  (+0.0%)
jetpack-cloud                             -39 B  (-0.0%)      -17 B  (-0.0%)
incoming-redirect                         -39 B  (-0.2%)      -17 B  (-0.2%)
import                                    -39 B  (-0.0%)      -17 B  (-0.0%)
home                                      -39 B  (-0.0%)      -17 B  (-0.0%)
gutenberg-editor                          -39 B  (-0.0%)      -17 B  (-0.0%)
google-my-business                        -39 B  (-0.0%)      -17 B  (-0.0%)
export                                    -39 B  (-0.0%)      -17 B  (-0.0%)
earn                                      -39 B  (-0.0%)      -17 B  (-0.0%)
customize                                 -39 B  (-0.0%)      -17 B  (-0.0%)
copy-site-flow                            -39 B  (-0.0%)      -17 B  (-0.0%)
concierge                                 -39 B  (-0.0%)      -17 B  (-0.0%)
comments                                  -39 B  (-0.0%)      -17 B  (-0.0%)
checkout                                  -39 B  (-0.0%)      -18 B  (-0.0%)
build-flow                                -39 B  (-0.0%)      -18 B  (-0.0%)
add-ons                                   -39 B  (-0.0%)      -17 B  (-0.0%)
activity                                  -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-team                     -39 B  (-0.0%)      -19 B  (-0.0%)
a8c-for-agencies-sites                    -39 B  (-0.0%)      +66 B  (+0.0%)
a8c-for-agencies-signup                   -39 B  (-0.0%)      -17 B  (-0.1%)
a8c-for-agencies-settings                 -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-referrals                -39 B  (-0.0%)      -19 B  (-0.0%)
a8c-for-agencies-purchases                -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-partner-directory        -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-overview                 -39 B  (-0.0%)      -19 B  (-0.0%)
a8c-for-agencies-migrations               -39 B  (-0.0%)      -17 B  (-0.0%)
a8c-for-agencies-marketplace              -39 B  (-0.0%)      -12 B  (-0.0%)
a8c-for-agencies-client                   -39 B  (-0.0%)      -19 B  (-0.0%)
plugins                                   +37 B  (+0.0%)      +89 B  (+0.0%)
settings-discussion                       +31 B  (+0.0%)    -1195 B  (-1.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~5042 bytes added 📈 [gzipped])

name                                                                              parsed_size            gzip_size
async-load-signup-steps-p2-complete-profile                                          +16527 B  (+18.4%)    +5017 B  (+17.8%)
async-load-signup-steps-plans-theme-preselected                                         +46 B   (+0.0%)      +62 B   (+0.0%)
async-load-signup-steps-plans                                                           +46 B   (+0.0%)      +62 B   (+0.0%)
async-load-signup-steps-page-picker                                                     -39 B   (-0.0%)      -17 B   (-0.0%)
async-load-signup-steps-emails                                                          -39 B   (-0.1%)      -17 B   (-0.1%)
async-load-signup-steps-domains                                                         -39 B   (-0.0%)      -17 B   (-0.0%)
async-load-purchase-modal-wrapper                                                       -39 B   (-0.0%)      -17 B   (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -39 B   (-0.0%)      -17 B   (-0.0%)
async-load-calypso-reader-sidebar                                                       -39 B   (-0.0%)      -20 B   (-0.1%)
async-load-calypso-my-sites-checkout-modal                                              -39 B   (-0.0%)      -17 B   (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

…age with that form

…ue with input jumping to pending value if you type in old email value.

…ubmission

matticbot · 2024-09-25T18:38:26Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/email-verification-form-and-notice on your sandbox.

Addison-Stavlo · 2024-09-25T19:23:14Z

Thanks for looking @javierarce and nice finds!

I updated the items you mentioned. The button should show a cursor on hover now, the dialog should close on overlay click, and scroll/focus functionality should work when using the modal from a separate page.

Addison-Stavlo · 2024-09-25T19:27:51Z

client/me/account/account-email-field.tsx

+		// Check for query param used to indicate a need to scroll to the input, this is added when
+		// redirecting to this page for the purpose of email change.
+		const urlQueryParams = new URL( window.location.href )?.searchParams;
+		const focusEmail = urlQueryParams.get( 'focusEmail' );
+		if ( focusEmail ) {
+			scrollAndFocus();
+			window.history.replaceState( {}, '', removeQueryArgs( window.location.href, 'focusEmail' ) );
+		}
+		// Listen for an event signalling to focus and scroll to the email field or button. This
+		// happens when we are already on a page with the input and need to trigger the
+		// functionality.
+		emailFormEventEmitter.addEventListener( 'highlightInput', scrollAndFocus );


Instead of using a query param for cases coming from another page, and an event emitter for cases on triggering this on the same page, I think the other option is moving this to Redux but I am conflicted. In both cases this is more of a signal/event to trigger functionality and not related to any state to manage, so Redux seems a little weird but we could probably manage it with a true/false toggle. But that seems like potential to get out-of-sync in some way (?), and generally it feels like extra boilerplate code and overkill for the purpose.

Id be curious thoughts of other developers reviewing.

I think the query param implementation makes sense. But does it need the same isEmailChangePending conditional check?

Also, I think the scroll only works the first time in Firefox. 🤔

Screen.Recording.2024-09-25.at.4.09.44.PM.mov

But does it need the same isEmailChangePending conditional check?

Yeah. If the change is pending the input is disabled, so instead we focus the button that cancels the pending change and unlocks the input. So either way that check is relevant to figure out what element to focus.

Also, I think the scroll only works the first time in Firefox. 🤔

Ah interesting! I don't think its just firefox.

So if you open the modal on /me/account and click "change" scroll works every time. But if you go to /me, open the modal, and click "change", the scroll/focus it only works if you haven't loaded /me/account yet.

I didn't think this would be the case but for whatever reason it seems like the email form component on /me/account doesn't dismount when you go back to /me. So the hook checking for the query param on mount to scroll to the input isn't firing since the component has been mounted and none of its dependencies have changed.

Ok not component mounting like i suspected, its the component loading before the window url is set in this case.

this should now be resolved with df256f2.

DustyReagan

This is testing well for me! I left a couple of comments.

Also, I have some feedback on the modal, but this could be suitable for a new issue.

I know this is existing copy, but it’s a little confusing. It says to "open the email and click the blue button", but the button in the modal is blue, could it mean that button? 😅 Additionally, if this is a second email change, the verification email is text-based, and there is no button in that email. Finally, the second paragraph in the modal has a smaller font size.

DustyReagan · 2024-09-25T19:39:39Z

client/me/style.scss

+				background: var(--color-surface);
+				border-radius: 8px; /* stylelint-disable-line scales/radii */
+				box-shadow: 0 0 17.4px 0 rgba(0, 0, 0, 0.05);
+				overflow-y: auto;
+				overflow-x: hidden;


I think this is removing padding on wide displays. Is this a possible regression or is this intentional?

DustyReagan · 2024-09-25T21:11:48Z

client/me/account/account-email-field.tsx

+		// Check for query param used to indicate a need to scroll to the input, this is added when
+		// redirecting to this page for the purpose of email change.
+		const urlQueryParams = new URL( window.location.href )?.searchParams;
+		const focusEmail = urlQueryParams.get( 'focusEmail' );
+		if ( focusEmail ) {
+			scrollAndFocus();
+			window.history.replaceState( {}, '', removeQueryArgs( window.location.href, 'focusEmail' ) );
+		}
+		// Listen for an event signalling to focus and scroll to the email field or button. This
+		// happens when we are already on a page with the input and need to trigger the
+		// functionality.
+		emailFormEventEmitter.addEventListener( 'highlightInput', scrollAndFocus );


I think the query param implementation makes sense. But does it need the same isEmailChangePending conditional check?

Also, I think the scroll only works the first time in Firefox. 🤔

Screen.Recording.2024-09-25.at.4.09.44.PM.mov

Addison-Stavlo · 2024-09-25T22:16:14Z

Also, I have some feedback on the modal, but this could be suitable for a new issue.

Note the modal itself has been updated separately in #94629 and waiting translations.

DustyReagan · 2024-09-25T22:30:20Z

Also, I have some feedback on the modal, but this could be suitable for a new issue.

Note the modal itself has been updated separately in #94629 and waiting translations.

Oh! I missed that. Thanks! 😄

… previously loaded

a8ci18n · 2024-09-30T09:35:51Z

Translation for this Pull Request has now been finished.

Addison-Stavlo · 2024-10-01T15:03:02Z

@DustyReagan - This has been updated to resolve the issues you found, and rebased to include the changes to the dialog modal that hopefully fit a bit better now. 😄

@javierarce Question for you. Above Dusty found a regression with our layout frame width in larger viewports. I have fixed the regression but it leaves a question for the Banner width. I have currently kept the banner width the same max-width as the content inside the frame:

I assume the above may be ideal. The other option is to let the banner expand with the edges of the frame itself which could feel a bit odd at wider widths:

Any thoughts there?

javierarce · 2024-10-01T15:11:02Z

@javierarce Question for you. #94683 (comment) a regression with our layout frame width in larger viewports. I have fixed the regression but it leaves a question for the Banner width. I have currently kept the banner width the same max-width as the content inside the frame:

In this case, I think doing that (keeping the banner width the same max-width as the content) is the right solution.

…nner in some circumstances

DustyReagan

Tests well and the changes look good to me! Nice work! 👍

Addison-Stavlo · 2024-10-01T16:24:29Z

Tests well and the changes look good to me! Nice work! 👍

Thanks for reviewing Dusty!

Note that im holding shipping for the new translations, as they don't seem to be fully in place yet:

Addison-Stavlo · 2024-10-07T12:55:01Z

It seems the string freeze check froze at 86% but was actually 100% done. Removing and re-adding the label seemed to update it. 🤷‍♀️

Addison-Stavlo added 2 commits September 18, 2024 14:33

remove notice under input and update copy

4a213f6

update success notices

c42514c

add fallback for one of those...

6c97449

Addison-Stavlo added 9 commits September 18, 2024 15:46

focus input on unlock

b4db10f

init new banner component

0cf32bd

add notice icon

34102cb

move notice out of content frame

3e17a05

style banner to fit and remove bad unused style rule for mobile

16fbe0f

add banner to account page

28fb9a4

update unlock field button styles

e9f4332

add note to self

c44914e

remove unused component

871f938

Addison-Stavlo self-assigned this Sep 18, 2024

Addison-Stavlo added 12 commits September 19, 2024 16:35

unlock and highlight input when change is clicked from modal on the p…

a68451b

…age with that form

ensure dialog closes on route change

d22a2e7

adjust button and anchor style to be consistent

17ef460

allow editing pending email

2e280a3

allow saving pending email change in security form

7fc58e5

show correct email with change notice on security input

4b96445

send success email message from account component

d763759

move emailToShow to component state and control with hooks, fixes iss…

f907459

…ue with input jumping to pending value if you type in old email value.

fix duplicate notices and only show email when it changed with that s…

8e58635

…ubmission

expand explanation text for domains and cancel pending cases

55c08e3

more commenting around emailSettingToShow state

1b58d8c

remove test file for removed component

d1e36fc

Addison-Stavlo mentioned this pull request Sep 20, 2024

Email Verification: Improve the UI of the Pending Email Change banner #94247

Closed

Addison-Stavlo requested a review from javierarce September 20, 2024 19:45

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2024

fix dialog to close on clicking backdrop

f616dc0

allow scroll/focus from external pages

cc2c7e6

Addison-Stavlo commented Sep 25, 2024

View reviewed changes

Addison-Stavlo added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Sep 25, 2024

DustyReagan reviewed Sep 25, 2024

View reviewed changes

allow scrollTo functionality from /me to work even if /me/account was…

df256f2

… previously loaded

Addison-Stavlo added 4 commits September 30, 2024 13:10

more merge conflict resolution

72a9322

fix css bracket removed in merge conflict

80b1d47

fix import order

6066b03

fix layout frame regression

eb753f0

fix issue with wrong email shown in modal, and href overtaking the ba…

450e2f8

…nner in some circumstances

DustyReagan approved these changes Oct 1, 2024

View reviewed changes

Addison-Stavlo mentioned this pull request Oct 1, 2024

Email verification banner - add basic unit tests. #95078

Merged

7 tasks

Aurorum mentioned this pull request Oct 4, 2024

Me: Improve "Change Username" Account Settings #94640

Merged

Addison-Stavlo added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging and removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Oct 7, 2024

Addison-Stavlo merged commit 36f4736 into trunk Oct 7, 2024
12 checks passed

Addison-Stavlo deleted the update/email-verification-form-and-notice branch October 7, 2024 12:55

github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update email verification items - remove old notices, add banner, update copies and success messages. #94683

Update email verification items - remove old notices, add banner, update copies and success messages. #94683

Addison-Stavlo commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited by matticbot

Loading

matticbot commented Sep 18, 2024 •

edited

Loading

matticbot commented Sep 25, 2024

Addison-Stavlo commented Sep 25, 2024

Addison-Stavlo Sep 25, 2024 •

edited

Loading

DustyReagan Sep 25, 2024

Addison-Stavlo Sep 25, 2024

Addison-Stavlo Sep 25, 2024 •

edited

Loading

Addison-Stavlo Sep 25, 2024

DustyReagan left a comment •

edited

Loading

DustyReagan Sep 25, 2024

DustyReagan Sep 25, 2024

Addison-Stavlo commented Sep 25, 2024 •

edited by DustyReagan

Loading

DustyReagan commented Sep 25, 2024

a8ci18n commented Sep 30, 2024

Addison-Stavlo commented Oct 1, 2024 •

edited

Loading

javierarce commented Oct 1, 2024

DustyReagan left a comment

Addison-Stavlo commented Oct 1, 2024

Addison-Stavlo commented Oct 7, 2024

Update email verification items - remove old notices, add banner, update copies and success messages. #94683

Update email verification items - remove old notices, add banner, update copies and success messages. #94683

Conversation

Addison-Stavlo commented Sep 18, 2024 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented Sep 18, 2024 • edited by matticbot Loading

matticbot commented Sep 18, 2024 • edited Loading

matticbot commented Sep 25, 2024

Addison-Stavlo commented Sep 25, 2024

Addison-Stavlo Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

DustyReagan Sep 25, 2024

Choose a reason for hiding this comment

Addison-Stavlo Sep 25, 2024

Choose a reason for hiding this comment

Addison-Stavlo Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

Addison-Stavlo Sep 25, 2024

Choose a reason for hiding this comment

DustyReagan left a comment • edited Loading

Choose a reason for hiding this comment

DustyReagan Sep 25, 2024

Choose a reason for hiding this comment

DustyReagan Sep 25, 2024

Choose a reason for hiding this comment

Addison-Stavlo commented Sep 25, 2024 • edited by DustyReagan Loading

DustyReagan commented Sep 25, 2024

a8ci18n commented Sep 30, 2024

Addison-Stavlo commented Oct 1, 2024 • edited Loading

javierarce commented Oct 1, 2024

DustyReagan left a comment

Choose a reason for hiding this comment

Addison-Stavlo commented Oct 1, 2024

Addison-Stavlo commented Oct 7, 2024

Addison-Stavlo commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited by matticbot

Loading

matticbot commented Sep 18, 2024 •

edited

Loading

Addison-Stavlo Sep 25, 2024 •

edited

Loading

Addison-Stavlo Sep 25, 2024 •

edited

Loading

DustyReagan left a comment •

edited

Loading

Addison-Stavlo commented Sep 25, 2024 •

edited by DustyReagan

Loading

Addison-Stavlo commented Oct 1, 2024 •

edited

Loading