-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Dyad with Dyad 2 in signup #11622
Conversation
client/lib/signup/themes-data.js
Outdated
@@ -45,12 +45,12 @@ export const themes = [ | |||
verticals: [] | |||
}, | |||
{ | |||
name: 'Dyad', | |||
slug: 'dyad', | |||
name: 'Dyad 2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we continue to refresh themes in Signup, I think it might be better for our users (esp. new ones) to leave off the name's "version" number. The slug and demo_uri can keep the number to make things work properly.
I can open a ticket to clean up the labels of the other refreshed themes.
Ref: pNEWy-95y-p2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, yes. Just catching up with the thread you started on the themes p2. I’ll make that adjustment now.
Adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Instructions for local testing:
Switch to this PR
Go to calypso.local:3000(?)/start/
Click "A grid of my latest posts"
Make sure Dyad 2 shows up instead of Dyad
Also, live testing can be done here:
https://calypso.live/?branch=update-themes-in-signup-dyad-2
Following @sixhours lead and pinging @michaeldcain for when you get a free moment.
Thanks!