Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Dyad with Dyad 2 in signup #11622

Merged
merged 2 commits into from
Apr 17, 2017
Merged

Conversation

allancole
Copy link
Contributor

Instructions for local testing:
Switch to this PR
Go to calypso.local:3000(?)/start/
Click "A grid of my latest posts"
Make sure Dyad 2 shows up instead of Dyad

Also, live testing can be done here:
https://calypso.live/?branch=update-themes-in-signup-dyad-2

Following @sixhours lead and pinging @michaeldcain for when you get a free moment.

Thanks!

@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] S Small sized issue label Feb 27, 2017
@allancole allancole added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 27, 2017
@@ -45,12 +45,12 @@ export const themes = [
verticals: []
},
{
name: 'Dyad',
slug: 'dyad',
name: 'Dyad 2',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we continue to refresh themes in Signup, I think it might be better for our users (esp. new ones) to leave off the name's "version" number. The slug and demo_uri can keep the number to make things work properly.

I can open a ticket to clean up the labels of the other refreshed themes.

Ref: pNEWy-95y-p2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes. Just catching up with the thread you started on the themes p2. I’ll make that adjustment now.

@michaeldcain
Copy link
Member

Following @sixhours lead and pinging @michaeldcain for when you get a free moment.

Adding the Signup label can also generally get a set of eyes on these quicker than pinging me :).

@michaeldcain michaeldcain added the [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. label Feb 28, 2017
@matticbot matticbot added the [Size] S Small sized issue label Mar 1, 2017
Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@michaeldcain michaeldcain added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 2, 2017
@allancole allancole merged commit 91968ca into master Apr 17, 2017
@michaeldcain michaeldcain deleted the update/themes-in-signup-dyad-2 branch April 17, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Size] S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants