Themes: Render layout last in routing #1186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Play with rendering a single tree layout last. This allows us to have one render tree. - For /design, render layout last, setting `primary` and `secondary` context props to the desired elements. - Edit sections loader to emit a callback when it's loaded the bundle, so we can add our last page handler last. There's lots of duplication and funkiness, but hopefully it demonstrates the idea.
ehg
added
[Type] Question
[Feature Group] Appearance & Themes
|
Since rebasing this is quite an endeavor, I'll file a new PR for that so we can keep this one around in case I miss anything. |
|
Closing now that #2896 is functional. |
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC, don't merge :)
Play with rendering a single tree layout last. This allows us to have
one render tree.
primaryandsecondarycontext props to the desired elements.
so we can add our last page handler last.
There's lots of duplication and funkiness, but hopefully it demonstrates
the idea.