Help: Use <ExternalLink /> component to add help links #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprasath002
added
the
[Feature Group] Support
nprasath002
added
[Status] In Progress
[Status] Needs Review
…ase, since it's the title of a thing and not just a phrase.
|
This looks good to me. I've added a fix to the title |
dllh
added
[Status] Ready to Merge
and removed
[Status] Needs Review
dllh
added a commit
that referenced
this pull request
Dec 7, 2015
Help: Use <ExternalLink /> component to add help links
|
Awesome, thanks! |
This was referenced Jul 16, 2020
This was referenced Nov 18, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1092
Changes by this PR
This PR replaces help links to use
<ExternalLink/>componentDesktop version
Mobile
version
Testing instructions
Go to http://calypso.localhost:3000/help. See the external links now have an icon that signals the user of non-calypso pages. Try different resolutions and see it fits well