Site Settings: Moves Site Address up to Site Profile card #1682
Conversation
alternatekev
added
[Type] Enhancement
[Feature] Site Settings
|
This gave me an idea—I think the address should be the second item, right below the title. That mimics the We should then put the blavatar interface to the left of those two fields and we create a sort of wysiwyg Site card editing interface. The tag line would go below that in a separate compact card with language. I'm not really sure visibility then would need it's own separate card. I don't love that we tried to get rid of the top and bottom save buttons by adding even more of them. |
Good idea. :) Looping @adambbecker here as well. |
|
👍 LGTM
+1 |
|
@mikeshelton1503 @rickybanister So Site Address would lose the bordering I've given it here, right? That's fine, I just wanted to confirm. |
|
Well, I guess eventually. We don't have a blavatar interface yet. I'd say your change could get merged (if other's agree) and just keep the whole |
alternatekev
added
[Status] Needs Review
removed redundant headers tidies up the form a bit removes the is-magic classname to show save buttons by default again removed extraneous is-magic class from css
alternatekev
force-pushed
the
try/move-site-address-to-site-profile
branch
from
25a28e9 to
e5cbf7e
Compare
I agree. It doesn't need to happen right now but I like the idea of it for the future. |
alternatekev
removed
the
[Status] Needs Design Review
| { this.languageOptions() } | ||
| { this.holidaySnowOption() } | ||
| </form> | ||
| </Card> | ||
| <SectionHeader label={ this.translate( 'Address and visibility' ) }> | ||
| <SectionHeader label={ this.translate( 'Visibility' ) }> | ||
| <Button |
There was a problem hiding this comment.
This is an added bonus - because Jetpack sites do not require the custom address controls, so the 'Address and Visibility' label is a bit confusing there. Now it will be just 'Visibility' . Win win!
|
Code looks solid. No errors and the custom address controls still work in the new layout. LGTM! I agree that the blavatar could be handled in an other PR. |
alternatekev
removed
the
[Status] Needs Review
…e-profile Site Settings: Moves Site Address up to Site Profile card
Currently, Site Address is a little buried, and kind of in the wrong place. There's no real reason it should be grouped with Visibility instead of Site Profile:
This PR cleans up the whole Site Profile card and moves Site Address to a CompactCard-looking area (replicated with the component's current use of
<fieldset />):pinging @mikeshelton1503 @rickybanister