Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media: Enable video editor in all environments #17246

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Media: Enable video editor in all environments #17246

merged 1 commit into from
Aug 16, 2017

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Aug 16, 2017 •
edited
Loading

Video editor is currently enabled in all environments except for production. This PR ensures that video editor now works everywhere.

Testing

  1. Edit a blog post.
  2. Click the + button in the editor toolbar and then select Add Media.
  3. Upload a video or select an existing video.
  4. Click the Edit button.
  5. Ensure that the Edit Thumbnail button is visible.

@donnapep donnapep added [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 16, 2017
@donnapep donnapep self-assigned this Aug 16, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/video-editor-to-production

@matticbot matticbot added the [Size] S Small sized issue label Aug 16, 2017
@donnapep donnapep requested review from ockham and ice9js August 16, 2017 14:03
@donnapep donnapep mentioned this pull request Aug 16, 2017
Merged
ockham
ockham approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🎉

@kraftbj kraftbj added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 16, 2017
@donnapep donnapep merged commit 3d76a98 into master Aug 16, 2017
@donnapep donnapep deleted the update/video-editor-to-production branch August 16, 2017 18:40
@donnapep
Copy link
Contributor Author

@kraftbj @chaselivingston Video editor is now in production. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ockham ockham ockham approved these changes

@kraftbj kraftbj kraftbj approved these changes

@ice9js ice9js Awaiting requested review from ice9js

Assignees

@donnapep donnapep

Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donnapep @matticbot @kraftbj @ockham