Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: increase autosave interval #29158

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

vindl
Copy link
Member

@vindl vindl commented Dec 5, 2018

Changes proposed in this Pull Request

Currently there is a core issue that causes autosaves to be triggered indefinitely for already published posts, even when there are no new changes (WordPress/gutenberg#12318). This issue was much more noticeable in Gutenlypso because our autosave interval was lower than in core (3 seconds). Bumping this value to 10 seconds as an interim solution, while this is properly resolved in core.

Testing instructions

  1. Starting at URL: https://wpcalypso.wordpress.com/block-editor/post/
  2. Create and publish a post.
  3. Trigger another autosave by making an edit.
  4. Make sure that looping autosave is delayed by 10 seconds now.

Fixes #29152

@vindl vindl added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Dec 5, 2018
@matticbot
Copy link
Contributor

@vindl vindl self-assigned this Dec 5, 2018
@vindl vindl requested a review from a team December 5, 2018 18:46
Copy link
Contributor

@rodrigoi rodrigoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Copons Copons changed the title Gutenberg: insrease autosave interval Gutenberg: increase autosave interval Dec 5, 2018
@kwight kwight merged commit b0f2a2c into master Dec 6, 2018
@kwight kwight deleted the fix/gutenberg-increase-autosave-interval branch December 6, 2018 00:20
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutenlypso: Autosave loops when triggered after publishing a post.
4 participants