-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIF Block: Placeholder State #30402
GIF Block: Placeholder State #30402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The form doesn't give me enough time to type what I'm looking for before displaying a GIF. See screen recording: https://cloudup.com/cagftUXpnfT
-
The form's width is not consistent between the placeholder and the iframe:
- I find it really strange to have a
text-align: center
on the input text. It's not consistent with the other inputs in Gutenberg.
Good points @thomasguillot 👍 I've made a few changes:
Here's what it looks like now, with Form placeholder below for reference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is in a good place, I'll merge it
Changes proposed in this Pull Request
Initial state of the block is now a Placeholder component and there is no longer a default Giphy image. This brings the block in line with Gutenberg design patterns.
This commit to Jetpack repo is part of the change: Automattic/jetpack@bd0a281
Testing instructions