Slideshow: Media Modal Issues #30786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersonrabb
added
Slideshow
[Status] Needs Review
|
LGTM 🚢 |
scruffian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR addresses a few bugs and imperfections related to adding/reordering/deleting images from the gallery using the Media Modal.
Side note about a related issue in Core: as part of this round of work I also investigated some Media Modal issues, which seem to be a Core problem that is equally affecting Gallery and Tiled Gallery:
#28959
https://github.com/Automattic/wp-calypso/issues/30065
And the upcoming resolution:
WordPress/gutenberg#12435
Testing instructions
JETPACK_BETA_BLOCKSinSettings->Jetpack Constants